Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string_decoder: fix bad utf8 character handling #7310

Merged
merged 2 commits into from
Jun 24, 2016
Merged

string_decoder: fix bad utf8 character handling #7310

merged 2 commits into from
Jun 24, 2016

Commits on Jun 24, 2016

  1. string_decoder: fix bad utf8 character handling 

    This commit fixes an issue when extra utf8 continuation bytes appear
at the end of a chunk of data, causing miscalculations to be made
when checking how many bytes are needed to decode a complete
character.

Fixes: nodejs#7308
PR-URL: nodejs#7310
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
    @mscdex
    mscdex committed Jun 24, 2016
    Configuration menu
    Copy the full SHA
    79ef3b6 View commit details
    Browse the repository at this point in the history

  2. test: add more UTF-8 StringDecoder tests 

    PR-URL: nodejs#7310
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
    @gagern @mscdex
    gagern authored and mscdex committed Jun 24, 2016
    Configuration menu
    Copy the full SHA
    5e8cbd7 View commit details
    Browse the repository at this point in the history