test: add test for exec() known issue #7375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
child_process
2 tasks
| const assert = require('assert'); | ||
| const exec = require('child_process').exec; | ||
|
|
||
| const keepAlive = setInterval(() => {}, 9999); |
There was a problem hiding this comment.
Won't the child process keep the event loop open? Works for me locally without the timer.
|
LGTM with a couple comments. |
|
@cjihrig Nits addressed. Also added a test for |
|
Changes LGTM |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 24, 2016
PR-URL: nodejs#7375 Refs: nodejs#7342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
|
Landed in c964574 |
Fishrock123
pushed a commit
that referenced
this pull request
Jun 27, 2016
PR-URL: #7375 Refs: #7342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
PR-URL: #7375 Refs: #7342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
|
@Trott lts? |
|
@thealphanerd If it lands and CI's cleanly, yes. |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
PR-URL: #7375 Refs: #7342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
PR-URL: #7375 Refs: #7342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
PR-URL: #7375 Refs: #7342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
PR-URL: #7375 Refs: #7342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test child_process
Description of change
Refs: #7342