deps: backport 102e3e87e7 from V8 upstream #7442
Conversation
|
/cc @nodejs/lts @nodejs/v8 This fixes a arm64 bug that has existed on v4.x for the duration of it's lifetime. I'd like to try and get this wrapped into v4.4.7 if possible ci: https://ci.nodejs.org/job/node-test-pull-request/3093/ |
|
/cc @nodejs/v8 Is it possible (or does it make sense) to get this upstreamed at some point, even though I'm assuming that that v8 branch is no longer supported? |
|
@mscdex I don't believe this branch is supported any longer, in the same way that v5.0.x is no longer supported we have nodejs/Release#111 open with the V8 team which leads me to believe that @natorion is the person to talk to about this |
|
@thealphanerd Ah yes, that LTS issue looks like what I had in mind. |
|
The change LGTM, but the V8 tests should be run. The V8-CI has two problems: 1) it doesn't support |
|
@ofrobots are you able to test this at all on your own infra? I can dig in a bit tomorrow, but I'm not sure that getting the V8 tests working on our CI for v4.x, specifically on arm64, is something we can get done quickly |
MylesBorins
force-pushed
the
V8-crankshaft-arm64-bug
branch
from
1537b47
to
8ed7392
Compare
|
here is a run on the V8 test ci: https://ci.nodejs.org/job/thealphanerd-test-commit-v8-linux/2/ This is working by rebasing this backport against my WIP branch for backporting the test runner. edit: it's green! |
|
Lgtm |
This commit backports a fix to a crankshaft bug affects arm64 systems.
Original commit message:
[arm64] Fix jssp based spill slot accesses in Crankshaft
Review URL: https://codereview.chromium.org/1401703003
Cr-Commit-Position: refs/heads/master@{nodejs#31304}
Fixes: nodejs#7417
PR-URL: nodejs#7442
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins
force-pushed
the
V8-crankshaft-arm64-bug
branch
from
8ed7392
to
207ade7
Compare
This commit backports a fix to a crankshaft bug affects arm64 systems.
Original commit message:
[arm64] Fix jssp based spill slot accesses in Crankshaft
Review URL: https://codereview.chromium.org/1401703003
Cr-Commit-Position: refs/heads/master@{#31304}
Fixes: #7417
PR-URL: #7442
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This LTS release comes with 89 commits. This includes 46 commits that
are docs related, 11 commits that are test related, 8 commits that are
build related, and 4 commits that are benchmark related.
Notable Changes:
- debugger:
- All properties of an array (aside from length) can now be printed
in the repl (cjihrig)
#6448
- npm:
- Upgrade npm to 2.15.8 (Rebecca Turner)
#7412
- stream:
- Fix for a bug that became more prevalent with the stream changes
that landed in v4.4.5. (Anna Henningsen)
#7160
- V8:
- Fix for a bug in crankshaft that was causing crashes on arm64
(Myles Borins)
#7442
- Add missing classes to postmortem info such as JSMap and JSSet
(evan.lucas)
#3792
This LTS release comes with 89 commits. This includes 46 commits that
are docs related, 11 commits that are test related, 8 commits that are
build related, and 4 commits that are benchmark related.
Notable Changes:
- debugger:
- All properties of an array (aside from length) can now be printed
in the repl (cjihrig)
#6448
- npm:
- Upgrade npm to 2.15.8 (Rebecca Turner)
#7412
- stream:
- Fix for a bug that became more prevalent with the stream changes
that landed in v4.4.5. (Anna Henningsen)
#7160
- V8:
- Fix for a bug in crankshaft that was causing crashes on arm64
(Myles Borins)
#7442
- Add missing classes to postmortem info such as JSMap and JSSet
(evan.lucas)
#3792
This commit backports a fix to a crankshaft bug affects arm64 systems.
Original commit message:
[arm64] Fix jssp based spill slot accesses in Crankshaft
Review URL: https://codereview.chromium.org/1401703003
Cr-Commit-Position: refs/heads/master@{#31304}
Fixes: nodejs/node#7417
PR-URL: nodejs/node#7442
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
deps
Description of change
This commit backports a fix to a crankshaft bug affects arm64 systems.
Original commit message:
Fixes: #7417