configure: reword help for --without-npm #7471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -370,7 +370,7 @@ parser.add_option('--without-etw', | |||
| parser.add_option('--without-npm', | |||
| action='store_true', | |||
| dest='without_npm', | |||
| help='don\'t install the bundled npm package manager') | |||
| help='don\'t install the bundled node package manager (npm)') | |||
There was a problem hiding this comment.
Maybe don\'t install the bundled npm (package manager)
There was a problem hiding this comment.
Yeah, I guess it's better with parenthesis but not sure if it's worth it
|
heh, I guess I kept that idea from their old website ;) |
|
Is there anyone building Node that doesn't know what npm is? |
|
since we're in here making changes anyway... would you mind |
|
Why not. LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 18, 2016
PR-URL: #7471 Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in ae0334a |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
PR-URL: #7471 Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
PR-URL: #7471 Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
PR-URL: #7471 Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
PR-URL: #7471 Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #7471 Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #7471 Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
build -> configure
Description of change
Reword help for
--without-npmin the configure script