Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

punycode: deprecate punycode module #7552

Closed
wants to merge 1 commit into from
Closed

punycode: deprecate punycode module #7552

wants to merge 1 commit into from

Commits on Jul 25, 2016

  1. punycode: deprecate punycode module 

    Currently, the punycode module is used in exactly one spot within
core (the url parser). With the recent switch to using the much
faster ICU based punycode implementation by default, the punycode
module is now only used when node happens to be built without icu.
This change moves the punycode module into internal and hard
deprecates `require('punycode')`. The hard deprecation notice is
only printed in ICU builds.

When the new WHATWG URL implementation lands, users will have access
to the URL.domainToUnicode() and URL.domainToASCII statics that are
defined as part of the standard interface.

The next step (in the next major) is to make it so that
internal/punycode.js is only included if the Node.js binary is built
without ICU.
    @jasnell
    jasnell committed Jul 25, 2016
    Configuration menu
    Copy the full SHA
    7b0c497 View commit details
    Browse the repository at this point in the history