Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 5.1.281.75 #7615

Merged
merged 1 commit into from
Jul 9, 2016
Merged

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jul 8, 2016

Pick up the latest branch-head for V8 5.1. Introduces a semver-minor
overload of v8::Function::New() for use by v8_inspector.

Refs: #7586

R=@nodejs/v8

CI: https://ci.nodejs.org/job/node-test-pull-request/3220/
CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/184/

@bnoordhuis bnoordhuis added the v8 engine Issues and PRs related to the V8 dependency. label Jul 8, 2016
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jul 8, 2016
@bnoordhuis bnoordhuis added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 8, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jul 8, 2016

LGTM

1 similar comment
@targos
Copy link
Member

targos commented Jul 8, 2016

LGTM

@indutny
Copy link
Member

indutny commented Jul 8, 2016

Rubber-stamp LGTM

@MylesBorins
Copy link
Contributor

LGTM if CI is green

Pick up the latest branch-head for V8 5.1.  Introduces a semver-minor
overload of v8::Function::New() for use by v8_inspector.

Refs: nodejs#7586
PR-URL: nodejs#7615
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@bnoordhuis bnoordhuis closed this Jul 9, 2016
@bnoordhuis bnoordhuis deleted the v8-5.1.281.75 branch July 9, 2016 07:14
@bnoordhuis bnoordhuis merged commit 245ac30 into nodejs:master Jul 9, 2016
@bnoordhuis
Copy link
Member Author

@Fishrock123 Out of curiosity, why did @nodejs-github-bot add the 'lib / src' label? All the changes were in deps/v8.

@MylesBorins
Copy link
Contributor

@bnoordhuis --> nodejs/github-bot#53

"labels: prevent deps from getting "lib / src" label "

@i5ting
Copy link

i5ting commented Jul 19, 2016

nice job

ofrobots added a commit to ofrobots/node that referenced this pull request Aug 25, 2016
Pick up the latest branch-head for V8 5.1. This branch brings in
improved language support and performance improvements. For full
details: http://v8project.blogspot.com/2016/04/v8-release-51.html

* Picks up the latest branch head for 5.1 [1]
* Edit v8 gitignore to allow trace_event copy
* Update V8 DEP trace_event as per deps/v8/DEPS [2]

[1] https://chromium.googlesource.com/v8/v8.git/+/5.1.281.75
[2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/c8c8665

Introduces a semver-minor overload of v8::Function::New() for use
by v8_inspector.

PR-URL: nodejs#8054
Refs: nodejs#7016
Refs: nodejs#7586
Refs: nodejs#7615
Reviewed-By: addaleax - Anna Henningsen <[email protected]>
Reviewed-By: thealphanerd - Myles Borins <[email protected]>
Reviewed-By: mhdawson - Michael Dawson <[email protected]>
Reviewed-By: evanlucas - Evan Lucas <[email protected]>
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants