repl: Use arrow functions for lexical this.
#7622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove usage of `var` in favor of `let` and `const`. Ref: #7414
| @@ -96,7 +96,7 @@ class LineParser { | |||
| } | |||
|
|
|||
| parseLine(line) { | |||
| var previous = null; | |||
| let previous = null; | |||
There was a problem hiding this comment.
We're still generally using var over let for performance reasons. I'm not sure how much that should matter in the REPL though.
|
This is outdated and probably no longer necessary. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
repl
Description of change
Removed code usage such as
var self = this;in favor of arrow functions and lexicalthis.Also removed usage of
varin favor ofletandconst.Ref: #7414