test: improve error message in test-tick-processor #7693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide additional information about values that indicate test failed.
| } | ||
| var log = matches[0]; | ||
| var out = cp.execSync(process.execPath + | ||
| ' --prof-process --call-graph-size=10 ' + log, | ||
| {encoding: 'utf8'}); | ||
| assert(pattern.test(out)); | ||
| assert(pattern.test(out), `${pattern} not matchint ${out}`); |
There was a problem hiding this comment.
matching?
Whoops, yes, fixed.
|
LGTM with a question. |
|
LGTM |
|
The commit appears to be missing metadata. |
|
Unfortunately, yes. Hopping on IRC to figure best thing to do about it, if anything... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 15, 2016
Provide additional information about values that indicate test failed. PR-URL: nodejs#7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
|
Re-landed in 9dc0651 and force pushed. :-| |
evanlucas
pushed a commit
that referenced
this pull request
Jul 18, 2016
Provide additional information about values that indicate test failed. PR-URL: #7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jul 20, 2016
Provide additional information about values that indicate test failed. PR-URL: #7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Provide additional information about values that indicate test failed. PR-URL: #7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Provide additional information about values that indicate test failed. PR-URL: #7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Provide additional information about values that indicate test failed. PR-URL: #7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Provide additional information about values that indicate test failed. PR-URL: #7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Provide additional information about values that indicate test failed.