eslintrc: rename files to an undeprecated format

[thefourtheye]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

eslintrc

Description of change

As per ESLint documentation,
http://eslint.org/docs/user-guide/configuring#configuration-file-formats
the file format .eslintrc is deprecated. This patch renames the files
but retains the contents as the structure is already in yaml format.

cc @silverwind, @Trott

[silverwind]

-1 from me, I like the consise .eslintrc more, and dotfiles with extension seem kind of strange. The argument for these extensions was syntax highlighting in editors IIRC, but it's kind of weak I'd say. I'd keep using .eslintrc until ESLint drops support for ich which is probably never :)

[Trott]

/cc @ronkorving

[Trott]

LGTM (assuming CI lint job runs OK) but I don't feel strongly enough about it to argue in favor of it over @silverwind's objection. I'm interested to know if others have strong opinions one way or the other (and why).

[targos]

I am not against the change but I don't have any strong opinion.

[ronkorving]

I added YAML support to ESLint a while ago, which I believe was the trigger for the deprecation. For the sake of syntax highlighting, I think it makes sense to make the switch.

[ChALkeR]

+0 on this one. It does make sense, but I doubt that hard deprecation or removal of .eslintrc support would happen anytime soon.

[cjihrig]

No strong opinion, but I think it makes sense to use a non-deprecated format.

[silverwind]

Keep in mind that this change is likely to break some tooling, like for example my favorite Sublime Text plugin.

Also older related issue: #6131

[ChALkeR]

@silverwind

Keep in mind that this change is likely to break some tooling, like for example my favorite Sublime Text plugin.

Ow. Btw, does it have a corresponding issue reported?

[silverwind]

@ChALkeR: roadhump/SublimeLinter-contrib-eslint_d#12

Still, I'd say my point stands as there's likely more undiscovered tools out there with similar issues.

[jasnell]

hmm... perhaps we keep this open for a while then to see if some of the tools we know would break with this can be fixed first?

Like @cjihrig I don't have a strong opinion on this but in general it LGTM as long as we don't break too many people

[thefourtheye]

Hmmm, not sure why this needed a rebase, but I anyway did.

[jasnell]

Ping ..looks like it's out of sync again. @thefourtheye is this still something you want?

[thefourtheye]

@jasnell Rebased.

@not-an-aardvark What do you think?

[not-an-aardvark]

+1 because .eslintrc is deprecated, but I don't have a strong opinion on this.

[thefourtheye]

@silverwind Provided roadhump/SublimeLinter-contrib-eslint_d#13 hasn't landed yet, do you think we should halt this?

[silverwind]

Depends on how strongly we crave that syntax highlighting 🤣. I guess I'm fine with this change if you feel strong about this, but I don't really see a necessity unless ESLint drops support for the old filename.

[thefourtheye]

My motivation comes from the fact that, we expect our users to move away from core's deprecated stuff, we also should try to do the same with other products 😄

[thefourtheye]

Landed in 16e3cf6. Thanks for the review people :-)