deps: backport 2bcbe2f from V8 upstream #7814
Merged
+3
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofrobots
added
v8 engine
|
LGTM but out of curiosity, is there a reason you opted for line buffering instead of no buffering? It seems the output is line oriented anyways so libc's newline scanning just adds unnecessary, if minimal, overhead. |
|
No strong reason other than to avoid any file watchers from observing partially complete lines. The output is indeed line oriented today; but the code may change in the future. The new line scanning is going to be negligible cost. |
ofrobots
force-pushed
the
perf-buffering-6.x
branch
from
bab39d4
to
bf3d4b2
Compare
|
Rebased, added a V8 patch-level bump. Relaunched CI: https://ci.nodejs.org/job/node-test-pull-request/3413/. |
|
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/244/. I think the Power BE machine has infrastructure issues. The rest are green. |
|
@nodejs/release: this is ready for landing onto |
|
works for me :] |
Excessive buffering of perf map files in V8 could cause profiles to be missing symbols at times. Original commit message: switch perf and ll_prof loggers to line buffering BUG=v8:5015 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2041243002 Cr-Commit-Position: refs/heads/master@{nodejs#36788} PR-URL: nodejs#7814 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
ofrobots
force-pushed
the
perf-buffering-6.x
branch
from
bf3d4b2
to
e82e804
Compare
|
Thanks. Landed on |
Merged
BethGriggs
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Aug 18, 2016
Excessive buffering of perf map files in V8 could cause profiles to be missing symbols at times. Original commit message: switch perf and ll_prof loggers to line buffering BUG=v8:5015 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2041243002 Cr-Commit-Position: refs/heads/master@{#36788} PR-URL: nodejs/node#7814 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Excessive buffering of perf map files in V8 could cause profiles to be missing symbols at times. Original commit message: switch perf and ll_prof loggers to line buffering BUG=v8:5015 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2041243002 Cr-Commit-Position: refs/heads/master@{#36788} PR-URL: #7814 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Excessive buffering of perf map files in V8 could cause profiles to be missing symbols at times. Original commit message: switch perf and ll_prof loggers to line buffering BUG=v8:5015 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2041243002 Cr-Commit-Position: refs/heads/master@{#36788} PR-URL: #7814 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Excessive buffering of perf map files in V8 could cause profiles to be missing symbols at times. Original commit message: switch perf and ll_prof loggers to line buffering BUG=v8:5015 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2041243002 Cr-Commit-Position: refs/heads/master@{#36788} PR-URL: #7814 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Closed
BethGriggs
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 9, 2016
Excessive buffering of perf map files in V8 could cause profiles to be missing symbols at times. Original commit message: switch perf and ll_prof loggers to line buffering BUG=v8:5015 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2041243002 Cr-Commit-Position: refs/heads/master@{#36788} PR-URL: nodejs/node#7814 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Note that this is not needed on
masteras V8 5.1 already contains this fix.R=@nodejs/v8
EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/3362/