Path Documentation Syntax Fixes #7817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The single quote in the ```text area was causing the words after it to be orange, when that probably isn't what was wanted. This issue doesn't occur on github's markdown renderer, but it does exist on the Node official website's docs. This fix makes is so escaping a quote in a text block isnt necessary
claudiorodriguez
added
doc
|
LGTM, just need to change the first line of the commit message to |
|
LGTM |
1 similar comment
|
LGTM |
|
Landed in 65a42ab. Thanks! |
cjihrig
pushed a commit
that referenced
this pull request
Aug 1, 2016
Single quotes in two of the examples were throwing off the formatting of the path documentation on the Node.js website. This commit expands two contractions to remove the offending quotes. PR-URL: #7817 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: James M Snell <[email protected]>
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
Single quotes in two of the examples were throwing off the formatting of the path documentation on the Node.js website. This commit expands two contractions to remove the offending quotes. PR-URL: #7817 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
2 tasks
Fishrock123
pushed a commit
that referenced
this pull request
Oct 5, 2016
Tangentially related to #7817 PR-URL: #8933 Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Tangentially related to #7817 PR-URL: #8933 Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Tangentially related to #7817 PR-URL: #8933 Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Documentation for the Path module
Description of change
The single quote in the ```text area was causing the words after it to
be orange, when that probably isn't what was wanted. This issue doesn't
occur on github's markdown renderer, but it does exist on the Node
official website's docs.
This fix makes is so escaping a quote in a text block isnt necessary