Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix hard coded deprecate message count #7927

Closed
wants to merge 1 commit into from
Closed

test: fix hard coded deprecate message count #7927

wants to merge 1 commit into from

Conversation

princejwesley
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, crypto

Description of change

This PR fixes hard coded deprecate message count

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 31, 2016
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Jul 31, 2016
@mscdex
Copy link
Contributor

mscdex commented Jul 31, 2016

LGTM pending CI: https://ci.nodejs.org/job/node-test-pull-request/3472/

@claudiorodriguez
Copy link
Contributor

LGTM

4 similar comments
@thefourtheye
Copy link
Contributor

LGTM

@santigimeno
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented Jul 31, 2016

LGTM

@doron2402
Copy link

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Aug 1, 2016

I'd reword the commit message as "test: don't hard code deprecation count". LGTM either way though.

jasnell pushed a commit that referenced this pull request Aug 1, 2016
@princejwesley @jasnell
test: don't hard code deprecation count
c52a973 
PR-URL: #7927
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 1, 2016

Landed in c52a973

@jasnell jasnell closed this Aug 1, 2016
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@princejwesley @cjihrig
test: don't hard code deprecation count
facd7da 
PR-URL: #7927
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@princejwesley @mscdex @claudiorodriguez @thefourtheye @santigimeno @jasnell @doron2402 @cjihrig @MylesBorins @nodejs-github-bot