-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove internal headers from addons #7947
Conversation
a7eaf5d
to
4ef5c85
Compare
@mscdex Whoops, looks like I removed one line too many. If you could rerun the CI that'd be great. |
The last CI run was green everywhere but FreeBSD. Trying again: https://ci.nodejs.org/job/node-test-pull-request/3505/ LGTM if it comes back green. I guess |
FreeBSD failure was this (probaby unrelated):
|
3rd CI came back green, thanks @cjihrig |
@bnoordhuis I'd appreciate a review from you as I'm changing your code. |
LGTM |
1 similar comment
LGTM |
PR-URL: #7947 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 9a0d26f! Thank you! |
Whoops, forgot to close when landing... |
PR-URL: #7947 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
neither of these files live in v4.x, adding dont land |
Backport-PR-URL: #16550 PR-URL: #7947 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
make -j4 test-addons
(UNIX), orvcbuild test-addons nosign
(Windows) passesAffected core subsystem(s)
test, addons
Description of change
Continuation of 3c85f4e (in #6734). Make the addons more like userland ones.
@bnoordhuis not sure whether
util.h
andutil-inl.h
were being used in openssl-binding/binding.cc. The asserts in test.js still seem to pass.EDIT: CI is green