Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport support for building as DLL on Windows to V6 #8084

Closed
wants to merge 2 commits into from
Closed

Backport support for building as DLL on Windows to V6 #8084

wants to merge 2 commits into from

Commits on Aug 21, 2016

  1. build: windows sharedlib support 

    Added "dll" option to vcbuild.bat
Insure that Unix SO name is not used on Windows (i.e. produce a .dll file)
Insure that Node and its V8 dependency link against the Visual C++ Runtime
dynamically.
Requires backported V8 patch, see PR 7802.

Ref: nodejs#7802

PR-URL: nodejs#7487
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
    @stefanmb
    stefanmb authored and Stewart Addison committed Aug 21, 2016
    Configuration menu
    Copy the full SHA
    3c0193d View commit details
    Browse the repository at this point in the history

  2. build: cherry pick V8 change for windows DLL support

    @stefanmb
    stefanmb authored and Stewart Addison committed Aug 21, 2016
    Configuration menu
    Copy the full SHA
    7bc8e35 View commit details
    Browse the repository at this point in the history