Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for assert.notStrictEqual() #8091

Closed
wants to merge 1 commit into from
Closed

test: add test for assert.notStrictEqual() #8091

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 13, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test assert

Description of change

There is currently no test for assert.notStrictEqual() throwing an
AssertionError when passed identical values. This change adds such a
test.

@Trott
test: add test for assert.notStrictEqual()
c2424a9 
There is currently no test for `assert.notStrictEqual()` throwing an
`AssertionError` when passed identical values. This change adds such a
test.
@Trott Trott added assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests. labels Aug 13, 2016
@targos
Copy link
Member

targos commented Aug 14, 2016

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/3662/

@fhinkel
Copy link
Member

fhinkel commented Aug 14, 2016

LGTM

3 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Aug 15, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 15, 2016

LGTM

@santigimeno
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented Aug 16, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3691/

green

Trott added a commit to Trott/io.js that referenced this pull request Aug 16, 2016
@Trott
test: add test for assert.notStrictEqual()
6478260 
There is currently no test for `assert.notStrictEqual()` throwing an
`AssertionError` when passed identical values. This change adds such a
test.

PR-URL: nodejs#8091
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@Trott
Copy link
Member Author

Trott commented Aug 16, 2016

Landed in 6478260

@Trott Trott closed this Aug 16, 2016
evanlucas pushed a commit that referenced this pull request Aug 20, 2016
@Trott @evanlucas
test: add test for assert.notStrictEqual()
853f605 
There is currently no test for `assert.notStrictEqual()` throwing an
`AssertionError` when passed identical values. This change adds such a
test.

PR-URL: #8091
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 13, 2016
@Trott
test: add test for assert.notStrictEqual()
ee54dc6 
There is currently no test for `assert.notStrictEqual()` throwing an
`AssertionError` when passed identical values. This change adds such a
test.

PR-URL: #8091
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
@Trott
test: add test for assert.notStrictEqual()
85c0235 
There is currently no test for `assert.notStrictEqual()` throwing an
`AssertionError` when passed identical values. This change adds such a
test.

PR-URL: #8091
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: add test for assert.notStrictEqual()
0a165cf 
There is currently no test for `assert.notStrictEqual()` throwing an
`AssertionError` when passed identical values. This change adds such a
test.

PR-URL: #8091
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: add test for assert.notStrictEqual()
c9af24d 
There is currently no test for `assert.notStrictEqual()` throwing an
`AssertionError` when passed identical values. This change adds such a
test.

PR-URL: #8091
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the notstrictequal branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @targos @fhinkel @cjihrig @jasnell @santigimeno @MylesBorins