-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "repl,util: insert carriage returns in output" #8141
Conversation
This reverts commit fce4b98. This was a breaking change and should have been marked semver-major.
LGTM, I was kinda worried about it. |
Marking the original PR as major. |
LGTM and I am still a bit uncomfortable about how there was never any actual reason for the change provided in the first place, other than “it fixed something in one of my projects”. |
This is great, I rather consider this a major change as well. Thanks everyone! |
What did this break? Why does it need to be reverted? The PR can be marked semver-major after it landed. |
@jasnell it breaks anything that relies on output only containing |
@jasnell look at the two related links in the OP for what it broke. This changed the output of util.format() |
Ok, so it did land in v6 .. that's unfortunate. Wouldn't we only revert it in v6 then? Or is this enough of a break that we don't want it in master either? |
I opened the PR on master because I agree with @addaleax's comment:
I feel like we need better justification to a pretty large breaking change like this |
Works for me. Would you mind adding a bit more of that justification to the commit message? |
FWIW I didn't recall seeing |
I would have read #7954 (comment) as a request to change it for |
Closing this one as #8143 is open for master. |
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
repl,util
Description of change
This reverts commit fce4b98.
This was a breaking change and should have been marked semver-major.
Ref: #8028
Related: hapijs/code#81
Related: #8138