-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add assert.notDeepStrictEqual() tests #8177
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no test coverage for `assert.notDeepStrictEqual()`. Add some minimal tests.
Trott
added
assert
Issues and PRs related to the assert subsystem.
test
Issues and PRs related to the tests.
labels
Aug 19, 2016
LGTM with CI: https://ci.nodejs.org/job/node-test-commit/4661/ |
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 22, 2016
There is no test coverage for `assert.notDeepStrictEqual()`. Add some minimal tests. PR-URL: nodejs#8177 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 181324e |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
There is no test coverage for `assert.notDeepStrictEqual()`. Add some minimal tests. PR-URL: #8177 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
There is no test coverage for `assert.notDeepStrictEqual()`. Add some minimal tests. PR-URL: #8177 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
There is no test coverage for `assert.notDeepStrictEqual()`. Add some minimal tests. PR-URL: #8177 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
There is no test coverage for `assert.notDeepStrictEqual()`. Add some minimal tests. PR-URL: #8177 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test assert
Description of change
There is no test coverage for
assert.notDeepStrictEqual()
. Add someminimal tests.