doc: add added: information for dgram
#8196
Conversation
nodejs-github-bot
added
dgram
lpinca
force-pushed
the
add/added-dgram
branch
from
5b95cbf
to
4c4ac71
Compare
|
|
||
| Returns an object containing the address information for a socket. | ||
| For UDP sockets, this object will contain `address`, `family` and `port` | ||
| properties. | ||
|
|
||
| ### socket.bind([port][, address][, callback]) | ||
| <!-- YAML | ||
| added: v0.1.99 |
There was a problem hiding this comment.
The callback argument was actually added in version 0.9.1. I'm not sure what version to use.
There are other inconsistencies like this below.
There was a problem hiding this comment.
I think this should be noted as updated: v0.9.1 even thought we have not that option :-(
There was a problem hiding this comment.
IIRC, we have not documenting when an argument or something like a property in an options object is added.
There was a problem hiding this comment.
Yeah, we don't currently document changes well. It'd be nice if we had per-function changelogs, like PHP.
|
bump |
|
LGTM although I haven't checked the validity of the data. Not sure if that's supposed to be part of the process on these or not. |
|
@Trott ... yes, double checking the validity of the versions is a good thing but it's also something that can be fixed separately if some of the details are off. |
|
LGTM |
PR-URL: #8196 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 379d916 |
PR-URL: nodejs#8196 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #8196 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
this is not landing cleanly on v4.x please feel free to backport |
PR-URL: nodejs#8196 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Ref: #8883 PR-URL: #8196 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Ref: #8883 PR-URL: #8196 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Ref: #8883 PR-URL: #8196 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Ref: #8883 PR-URL: #8196 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578