Revert "crypto: add crypto.timingSafeEqual" #8225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0fc5e0d. Additional testing indicates that there may still be timing issues with this implementation. Revert in order to give more time for testing before this goes out into a release... Refs: nodejs#8040 Refs: nodejs#8203
nodejs-github-bot
added
crypto
This was referenced Aug 22, 2016
|
LGTM @nodejs/crypto |
|
LGTM. This looks like it was a clean revert, no nudging necessary? |
2 tasks
|
Given the rather large impact this has on our CI results, I'd be OK with this landing sooner rather than waiting the usual 48 hours as long as it's a clean revert and there's no concerns from @nodejs/crypto. |
|
+1 for sooner rather than later. |
|
It is a clean revert. There were no conflicts. |
jasnell
added a commit
that referenced
this pull request
Aug 23, 2016
This reverts commit 0fc5e0d. Additional testing indicates that there may still be timing issues with this implementation. Revert in order to give more time for testing before this goes out into a release... Refs: #8040 Refs: #8203 PR-URL: #8225 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in 0764bc4 |
4 tasks
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
crypto
Description of change
This reverts commit 0fc5e0d.
Additional testing indicates that there may still be timing issues with this implementation. Revert in order to give more time for testing before this goes out into a release...
Refs: #8040
Refs: #8203
/cc @Trott @not-an-aardvark