test: refactor/cleanup a number of cluster tests #8261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
cluster
| @@ -82,15 +79,15 @@ function worker() { | |||
| // Create udp socket and start listening. | |||
| var socket = dgram.createSocket('udp4'); | |||
|
|
|||
| socket.on('message', function(data, info) { | |||
| socket.on('message', common.mustCall((data, info) => { | |||
| received++; | |||
|
|
|||
| // Every 10 messages, notify the master. | |||
| if (received == PACKETS_PER_WORKER) { | |||
There was a problem hiding this comment.
Nit: Since you're already working nearby, maybe change == to ===?
|
|
||
| //Kill process when worker is killed | ||
| cluster.on('exit', function() { | ||
| cluster.on('exit', common.mustCall(() => { | ||
| process.exit(0); |
There was a problem hiding this comment.
While you're here... I think process.exit(0) can be removed.
|
The changes LGTM with a couple of comments / suggestions. |
* Move shared code into common * Favor use of strictEqual * Add some missing common.mustCalls * Other general cleanup
jasnell
force-pushed
the
refactor-cluster-tests
branch
from
e03376c
to
f6a2c45
Compare
|
@santigimeno ... updated! PTAL! |
|
LGTM with one tiny comment that you can ignore. Thanks! |
|
Trying again due to a build bot failure: https://ci.nodejs.org/job/node-test-pull-request/3913/ |
|
CI was green. woo! |
jasnell
added a commit
that referenced
this pull request
Sep 1, 2016
* Move shared code into common * Favor use of strictEqual * Add some missing common.mustCalls * Other general cleanup PR-URL: #8261 Reviewed-By: Santiago Gimeno <[email protected]>
|
Landed in baa0ffd |
|
Looking at the AIX runs I've seen a few failures of: parallel/test-cluster-dgram-1 I wonder if its related to this change ? |
|
If the failures are new, entirely possible. Have a stack trace? |
|
opened this issue to track #8380 |
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Sep 2, 2016
We've started to see frequent failures in test/parallel/test-cluster-dgram-1.js on AIX since the refactoring in nodejs#8261. Revert changes until we have time to investigate properly.
2 tasks
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
* Move shared code into common * Favor use of strictEqual * Add some missing common.mustCalls * Other general cleanup PR-URL: nodejs#8261 Reviewed-By: Santiago Gimeno <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
* Move shared code into common * Favor use of strictEqual * Add some missing common.mustCalls * Other general cleanup PR-URL: #8261 Reviewed-By: Santiago Gimeno <[email protected]>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, cluster
Description of change
Some general refactoring / improvements to various cluster related tests: