Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add not-an-aardvark to collaborators #8525

Closed
wants to merge 1 commit into from
Closed

doc: add not-an-aardvark to collaborators #8525

wants to merge 1 commit into from

Conversation

not-an-aardvark
Copy link
Contributor

🎉

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Adds me to the collaborators list!

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 13, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Sep 13, 2016

LGTM

@addaleax
Copy link
Member

LGTM! \o/

@not-an-aardvark
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/4037/

@evanlucas
Copy link
Contributor

yay! LGTM

@Trott
Copy link
Member

Trott commented Sep 13, 2016

LGTM

@not-an-aardvark
Copy link
Contributor Author

Landed in ead820d

not-an-aardvark added a commit that referenced this pull request Sep 13, 2016
@not-an-aardvark
doc: add not-an-aardvark to collaborators
ead820d 
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@not-an-aardvark not-an-aardvark deleted the add-self-to-readme branch September 13, 2016 22:44
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@not-an-aardvark
doc: add not-an-aardvark to collaborators
919c993 
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@not-an-aardvark
doc: add not-an-aardvark to collaborators
566f3b9 
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@not-an-aardvark @Fishrock123
doc: add not-an-aardvark to collaborators
125df45 
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@not-an-aardvark @rvagg
doc: add not-an-aardvark to collaborators
b80d8ed 
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@not-an-aardvark @MylesBorins
doc: add not-an-aardvark to collaborators
88bb65d 
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@not-an-aardvark @cjihrig @addaleax @evanlucas @Trott @MylesBorins @nodejs-github-bot