util: Add format for SharedArrayBuffer #8587

yosuke-furukawa · 2016-09-17T09:16:14Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

util

Description of change

SharedArrayBuffer is a new global object to share memories between workers.
Currently workers does not work in node, but future v8 has those new global objects.
This change supports a format for SharedArrayBuffer.

Note: this PR is from code-and-learn
nodejs/code-and-learn#56 (comment)

Fishrock123 · 2016-09-17T17:53:47Z

Shouldn't we wait for this feature to become publicly available in V8 first?

addaleax · 2016-09-17T18:04:57Z

lib/util.js

+  } else if (binding.isSharedArrayBuffer(value)) {
+    braces = ['{', '}'];
+    keys.unshift('byteLength');
+    visibleKeys.byteLength = true;


Just a suggestion but I think you can join this with the isArrayBuffer case using ||.

addaleax · 2016-09-17T18:05:00Z

src/node_util.cc

@@ -28,7 +28,8 @@ using v8::Value;
  V(isRegExp, IsRegExp)                                                       \
  V(isSet, IsSet)                                                             \
  V(isSetIterator, IsSetIterator)                                             \
-  V(isTypedArray, IsTypedArray)
+  V(isTypedArray, IsTypedArray)                                               \
+  V(isSharedArrayBuffer, IsSharedArrayBuffer)


Note: If you rebase against master, this one should already be in the list due to #8510. Feel free to sort that in alphabetically, though. :)

addaleax · 2016-09-17T18:05:29Z

test/parallel/test-util-format-shared-arraybuffer.js

+  uint8Array[i] = 'a';
+}
+
+assert.equal(util.format(sab), 'SharedArrayBuffer { byteLength: 4 }');


assert.strictEqual?

addaleax · 2016-09-17T18:07:24Z

Shouldn't we wait for this feature to become publicly available in V8 first?

Well, we’ve already done this for SIMD, and I think it’s okay to be prepared for a release where SABs work without --harmony flags.

yosuke-furukawa · 2016-09-18T07:22:41Z

Thank you for your review, I fixed them.

benjamingr · 2016-09-18T11:40:59Z

I think we should wait until we have a strategy related to SharedArrayBuffer first. @petkaantonov worked on a PR that would enable just that (using SharedArrayBuffer like that) but afaik it is stalled.

alistairjcbrown · 2016-09-19T09:35:55Z

lib/util.js

@@ -449,7 +449,7 @@ function formatValue(ctx, value, recurseTimes) {
    }
    // Fast path for ArrayBuffer.  Can't do the same for DataView because it
    // has a non-primitive .buffer property that we need to recurse for.


Worth updating this comment too to include reference to SharedArrayBuffer?

alistairjcbrown · 2016-09-19T09:36:13Z

src/node_util.cc

@@ -29,6 +28,7 @@ using v8::Value;
  V(isRegExp, IsRegExp)                                                       \
  V(isSet, IsSet)                                                             \
  V(isSetIterator, IsSetIterator)                                             \
+  V(isSharedArrayBuffer, IsSharedArrayBuffer)                                 \


Looks like this changes in this file can be removed (it's just moving the line).

I just sort the line in alphabetical order.

alistairjcbrown · 2016-09-19T09:36:56Z

test/parallel/test-util-format-shared-arraybuffer.js

+const util = require('util');
+
+// Pacify eslint.
+const SharedArrayBuffer = global.SharedArrayBuffer;


I don't know if there's a preference, but we can use eslints global comment to pacify too

/* global SharedArrayBuffer */

yosuke-furukawa · 2016-09-19T10:54:20Z

@benjamingr
I think --harmony option features like SharedArrayBuffer, SIMD are experimental, but we have already related features ( #8510, #7864 ).

benjamingr · 2016-09-19T10:56:06Z

@yosuke-furukawa and what exactly would one do with a SharedArrayBuffer in Node? The underlying cluster implementation does not support it.

alistairjcbrown · 2016-09-19T17:31:44Z

@benjamingr Does that matter for this PR? The data structure is available in node (behind the v8 flag), and when used, the inspect output does not mirror that of the ArrayBuffer. Adding this functionality to the inspect util now means that, when it is being more actively used, more useful information is being output.

$ node --harmony_sharedarraybuffer
> new ArrayBuffer(4)
ArrayBuffer { byteLength: 4 }
> new SharedArrayBuffer(4)
SharedArrayBuffer {}

jasnell

I'm good with adding this now. LGTM

addaleax

LGTM, CI: https://ci.nodejs.org/job/node-test-commit/5294/

PR-URL: #8587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

jasnell · 2016-09-26T15:10:21Z

Landed in ce7d307. Thank you!

PR-URL: #8587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: nodejs#8587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #8587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. labels Sep 17, 2016

yosuke-furukawa mentioned this pull request Sep 17, 2016

util: support SharedArrayBuffer in inspect #8612

Closed

4 tasks

addaleax reviewed Sep 17, 2016

View reviewed changes

yosuke-furukawa force-pushed the format_sharedarraybuffer branch from 8bc1f65 to 4e4ab76 Compare September 18, 2016 07:20

alistairjcbrown reviewed Sep 19, 2016

View reviewed changes

util: Add format for SharedArrayBuffer

e5c6df2

yosuke-furukawa force-pushed the format_sharedarraybuffer branch from 4e4ab76 to e5c6df2 Compare September 19, 2016 10:51

jasnell approved these changes Sep 20, 2016

View reviewed changes

Trott force-pushed the master branch from b0df363 to c5ce7f4 Compare September 21, 2016 00:09

addaleax approved these changes Sep 24, 2016

View reviewed changes

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 24, 2016

jasnell pushed a commit that referenced this pull request Sep 26, 2016

util: Add format for SharedArrayBuffer

ce7d307

PR-URL: #8587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

jasnell closed this Sep 26, 2016

jasnell pushed a commit that referenced this pull request Sep 29, 2016

util: Add format for SharedArrayBuffer

e97fe46

PR-URL: #8587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016

util: Add format for SharedArrayBuffer

5eb6472

PR-URL: nodejs#8587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016

util: Add format for SharedArrayBuffer

fc68b12

PR-URL: #8587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: Add format for SharedArrayBuffer #8587

util: Add format for SharedArrayBuffer #8587

yosuke-furukawa commented Sep 17, 2016 •

edited

Loading

Fishrock123 commented Sep 17, 2016

addaleax Sep 17, 2016

addaleax Sep 17, 2016

addaleax Sep 17, 2016

addaleax commented Sep 17, 2016

yosuke-furukawa commented Sep 18, 2016

benjamingr commented Sep 18, 2016

alistairjcbrown Sep 19, 2016

yosuke-furukawa Sep 19, 2016

alistairjcbrown Sep 19, 2016

yosuke-furukawa Sep 19, 2016

alistairjcbrown Sep 19, 2016

yosuke-furukawa Sep 19, 2016

yosuke-furukawa commented Sep 19, 2016

benjamingr commented Sep 19, 2016

alistairjcbrown commented Sep 19, 2016 •

edited

Loading

jasnell left a comment

addaleax left a comment

jasnell commented Sep 26, 2016

util: Add format for SharedArrayBuffer #8587

util: Add format for SharedArrayBuffer #8587

Conversation

yosuke-furukawa commented Sep 17, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

Fishrock123 commented Sep 17, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addaleax commented Sep 17, 2016

yosuke-furukawa commented Sep 18, 2016

benjamingr commented Sep 18, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yosuke-furukawa commented Sep 19, 2016

benjamingr commented Sep 19, 2016

alistairjcbrown commented Sep 19, 2016 • edited Loading

jasnell left a comment

Choose a reason for hiding this comment

addaleax left a comment

Choose a reason for hiding this comment

jasnell commented Sep 26, 2016

yosuke-furukawa commented Sep 17, 2016 •

edited

Loading

alistairjcbrown commented Sep 19, 2016 •

edited

Loading