Upgrade to openssl-1.0.2i v4.x #8719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces all sources of openssl-1.0.2i.tar.gz into deps/openssl/openssl PR-URL: nodejs#8714 Reviewed-By: Fedor Indutny <[email protected]>
All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. PR-URL: nodejs#8714 Reviewed-By: Fedor Indutny <[email protected]>
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . Fixes: nodejs#589 PR-URL: nodejs#1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
See https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html iojs needs to stop using masm and move to nasm or yasm on Win32. Fixes: nodejs#589 PR-URL: nodejs#1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Reapply b910613 . Fixes: nodejs#589 PR-URL: nodejs#1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. Fixes: nodejs#1461 PR-URL: nodejs#1836 Reviewed-By: Ben Noordhuis <[email protected]>
Regenerate asm files with Makefile and CC=gcc and ASM=gcc where gcc-5.4.0. Also asm files in asm_obsolete dir to support old compiler and assembler are regenerated without CC and ASM envs. PR-URL: nodejs#8714 Reviewed-By: Fedor Indutny <[email protected]>
openssl command does not allow to both "-ssl3" and "-no_tls1". A protocol connecting to the server is only specified. PR-URL: nodejs#8714 Reviewed-By: Fedor Indutny <[email protected]>
MylesBorins
added
tls
nodejs-github-bot
added
openssl
|
LGTM if CI is ok. |
shigeki
approved these changes
Sep 22, 2016
mscdex
removed
crypto
|
@mhdawson can you look into the failures on AIX? https://ci.nodejs.org/job/node-test-commit-aix/1022/nodes=aix61-ppc64/ edit: 2 of the three tests look infra related... re running tests on AIX to be safe https://ci.nodejs.org/job/node-test-commit-aix/1025/ edit 2: failed again running ci against v4.x to see if failures exist on entire release line edit 3: these are known flaky's merging |
|
/cc @nodejs/build @nodejs/bots it looks like the failed tests were not updated here. Might be worth taking a look into |
|
AIX failures are marked as flaky and so are expected: These are the ones I saw: not ok 510 parallel/test-https-connect-address-family I believe the connect-address-family ones are flaky on other platforms as well (something to do with IPV6 configuration I think) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
crypto, tls and https
Description of change
Ref: #8714
ci: https://ci.nodejs.org/job/node-test-pull-request/4214/
CC: @indutny or @bnoordhuis or @shigeki