adding test for _stream.writable ended state
#8778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Sep 27, 2016
|
|
||
| assert.strictEqual(writable._writableState.ended, false); | ||
|
|
||
| writable.end('testing ended state', () => { |
There was a problem hiding this comment.
The callback here should be wrapped in a common.mustCall() in order to verify that it actually does get called.
|
LGTM |
mcollina
pushed a commit
that referenced
this pull request
Sep 30, 2016
PR-URL: #8778 Ref: #8686 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
CI failures were not related. |
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
PR-URL: #8778 Ref: #8686 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 6, 2016
PR-URL: #8778 Ref: #8686 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
PR-URL: #8778 Ref: #8686 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8778 Ref: #8686 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8778 Ref: #8686 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #8778 Ref: #8686 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Issue related: #8686