-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: persist net.Socket options before connect #880
Commits on Apr 17, 2015
-
Configuration menu - View commit details
-
Copy full SHA for e61ee49 - Browse repository at this point
Copy the full SHA e61ee49View commit details
Commits on Apr 18, 2015
-
This commit: - fixes development branch (v1.x -> master) - updates stability index wording - use iojs binary instead of node PR-URL: nodejs#1466 Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6870764 - Browse repository at this point
Copy the full SHA 6870764View commit details -
Revert "http: don't bother making a copy of the options"
This reverts commit 06cfff9. Reverted because it introduced a regression where (because options were modified in the later functionality) options.host and options.port would be overridden with values provided in other, supported ways. PR-URL: nodejs#1467 Reviewed-By: Ben Noordhuis <[email protected]>
5Configuration menu - View commit details
-
Copy full SHA for 7180597 - Browse repository at this point
Copy the full SHA 7180597View commit details -
test: add test for 06cfff9 regression
This commit adds a test to ensure all options are NOT modified after passing them to http.request. Specifically options.host and options.port are the most prominent that would previously error, but add the other options that have default values. options.host and options.port were overridden for the one-argument net.createConnection(options) call. PR-URL: nodejs#1467 Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6bf85bc - Browse repository at this point
Copy the full SHA 6bf85bcView commit details
Commits on Apr 21, 2015
-
This brings in the '%PYTHON%' revert, and restores the correct NODE_MODULE_VERSION. PR-URL: nodejs#1482 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 59a5c98 - Browse repository at this point
Copy the full SHA 59a5c98View commit details -
Update AUTHORS list using tools/update-authors.sh PR-URL: nodejs#1476 Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2632775 - Browse repository at this point
Copy the full SHA 2632775View commit details
Commits on Apr 23, 2015
-
doc: add spaces to child.kill example
PR-URL: nodejs#1503 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b16a328 - Browse repository at this point
Copy the full SHA b16a328View commit details -
doc: add Fishrock123 to the TC
as per nodejs#1502 PR-URL: nodejs#1507 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 22aafa5 - Browse repository at this point
Copy the full SHA 22aafa5View commit details -
tls_wrap: use localhost if options.host is empty
tls.connect(options) with no options.host should accept a certificate with CN: 'localhost'. Fix Error: Hostname/IP doesn't match certificate's altnames: "Host: undefined. is not cert's CN: localhost" 'localhost' is not added directly to defaults because that is not always desired (for example, when using options.socket) PR-URL: nodejs#1493 Fixes: nodejs#1489 Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a7d7463 - Browse repository at this point
Copy the full SHA a7d7463View commit details -
module: remove '' from Module.globalPaths
If `$NODE_PATH` contains trailing separators, `Module.globalPaths` will contains empty strings. When `Module` try to resolve a module's path, `path.resolve('', 'index.js')` will boil down to `$PWD/index.js`, which makes sub modules can access global modules and get unexpected result. PR-URL: nodejs#1488 Reviewed-By: Roman Reiss <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7384ca8 - Browse repository at this point
Copy the full SHA 7384ca8View commit details -
Update the remaining markdown files to refer to the master branch. PR-URL: nodejs#1511 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bb254b5 - Browse repository at this point
Copy the full SHA bb254b5View commit details -
buffer: little improve for Buffer.concat method
When buffer list less than 2, no need to calculate the length. The change's benchmark result is here: https://gist.github.com/JacksonTian/2c9e2bdec00018e010e6 It improve 15% ~ 25% speed when list only have one buffer, to other cases no effect. PR-URL: nodejs#1437 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3d3083b - Browse repository at this point
Copy the full SHA 3d3083bView commit details
Commits on Apr 24, 2015
-
Separates out the lookup logic for net.Socket. In the event the `host` property is an IP address, the lookup is skipped. PR-URL: nodejs#1505 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1bef717 - Browse repository at this point
Copy the full SHA 1bef717View commit details -
net: add lookup option to Socket.prototype.connect
Allows customization of the lookup function used when Socket.prototype.connect is called using a hostname. PR-URL: nodejs#1505 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4abe2fa - Browse repository at this point
Copy the full SHA 4abe2faView commit details -
net: persist net.Socket options before connect
Remembers net.Socket options called before connect and retroactively applies them after the handle has been created. This change makes the following function calls more user-friendly: - setKeepAlive() - setNoDelay() - ref() - unref() Related: nodejs/node-v0.x-archive#7077 and nodejs/node-v0.x-archive#8572
Configuration menu - View commit details
-
Copy full SHA for 102a993 - Browse repository at this point
Copy the full SHA 102a993View commit details