https: name anonymous functions in https #9217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 21, 2016
lpinca
approved these changes
Oct 24, 2016
targos
approved these changes
Oct 24, 2016
2 tasks
|
I think that it is fine (but not necessary?) to also name prototype functions. Still LGTM. |
related to commit ef030da which is naming anonymous functions to standardize the code
As stated in #9252 anonymous callback functions should be named, but not functions that are assigned to a property on a variable because the name is inferred from the assignment
related to commit ef030da which is naming anonymous functions to standardize the code
|
Landed in: 1f45d7a Thanks for the contribution. |
italoacasas
pushed a commit
that referenced
this pull request
Nov 25, 2016
Naming anonymous function in the https module PR-URL: #9217 Ref: #8913 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Naming anonymous function in the https module PR-URL: #9217 Ref: #8913 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
added
the
baking-for-lts
MylesBorins
added
dont-land-on-v6.x
and removed
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
https
Description of change
https: name anonymous functions in https
name anonymous functions in https module
the changes are related to commits ef030da and accf410
which are naming anonymous functions to standardize the code
and help debugging, also with Ref: #8913