process: add `externalMemory` to process.memoryUsage #9587

indutny · 2016-11-12T21:56:48Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

process

Description of change

Well, title says it all.

cc @nodejs/collaborators

indutny · 2016-11-12T21:57:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4833/

mscdex · 2016-11-12T23:34:21Z

Can we shorten it to just 'external'?

indutny · 2016-11-12T23:45:46Z

Mmm... ok :)

indutny · 2016-11-12T23:49:46Z

Fixed.

mcollina

LGTM

targos · 2016-11-13T09:22:11Z

doc/api/process.md

 }
 ```

 `heapTotal` and `heapUsed` refer to V8's memory usage.
+`external` refer to the memory usage of C++ objects bound to JavaScript


nit: refers

indutny · 2016-11-13T09:32:00Z

Thank you for review! Will land it tomorrow, unless anyone will object.

jbergstroem · 2016-11-13T16:19:22Z

@indutny just a heads up on commit title length: https://ci.nodejs.org/job/node-test-commitmsg/27/tapTestReport/

silverwind

LGTM, suggesting renaming commit to

process: add process.memoryUsage.external

addaleax

LGTM

indutny · 2016-11-13T20:49:00Z

Landed in 5a61b99, thank you everyone!

PR-URL: #9587 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

bnoordhuis · 2016-11-13T20:53:55Z

@indutny Remember the 48/72 hour rule.

indutny · 2016-11-13T21:04:29Z

Gosh, 48? Not 24? Sorry!

PR-URL: #9587 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

This is a security release impacting Windows 10 users. Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 - Fixed a potential buffer overflow when writing data to console on Windows 10. (CVE-2016-9551) * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * tls: Fixed a memory leak when writes were queued on TLS connection that was destroyed during handshake. (Fedor Indutny) #9626 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

This is a security release impacting Windows 10 users. Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) nodejs/node#9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) nodejs/node#9296 & nodejs/node#9296 * libuv: Upgrade to v1.10.1 (cjihrig) nodejs/node#9647 - Fixed a potential buffer overflow when writing data to console on Windows 10. (CVE-2016-9551) * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) nodejs/node#9587 * tls: Fixed a memory leak when writes were queued on TLS connection that was destroyed during handshake. (Fedor Indutny) nodejs/node#9626 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) nodejs/node#9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) nodejs/node#8610 Signed-off-by: Ilkka Myller <[email protected]>

PR-URL: #9587 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Notable Changes: * child_process: add shell option to spawn() (cjihrig) #4598 * crypto: * add ALPN Support (Shigeki Ohtsu) #2564 * allow adding extra certs to well-known CAs (Sam Roberts) #9139 * deps: * v8: expose statistics about heap spaces (Ben Ripkens) #4463 * fs: add the fs.mkdtemp() function. (Florian MARGAINE) #5333 * process: * add `externalMemory` to `process` (Fedor Indutny) #9587 * add process.cpuUsage() (Patrick Mueller) #10796

Notable Changes: The SEMVER-MINOR changes include: * crypto: allow adding extra certs to well-known CAs (Sam Roberts) #9139 * deps: Upgrade INTL ICU to version 58 (Steven R. Loomis) #9234 * process: add `process.memoryUsage.external` (Fedor Indutny) #9587 * src: add wrapper for process.emitWarning() (Sam Roberts) #9139 Notable SEMVER-PATCH changes include: * fs: cache non-symlinks in realpathSync. (Jeremy Yallop) #10253 * repl: allow autocompletion for scoped packages (Evan Lucas) #10296

Notable Changes: * child_process: add shell option to spawn() (cjihrig) #4598 * crypto: * add ALPN Support (Shigeki Ohtsu) #2564 * allow adding extra certs to well-known CAs (Sam Roberts) #9139 * deps: * v8: expose statistics about heap spaces (Ben Ripkens) #4463 * fs: add the fs.mkdtemp() function. (Florian MARGAINE) #5333 * process: * add `externalMemory` to `process` (Fedor Indutny) #9587 * add process.cpuUsage() (Patrick Mueller) #10796 PR-URL: #10973

Notable Changes: The SEMVER-MINOR changes include: * crypto: allow adding extra certs to well-known CAs (Sam Roberts) #9139 * deps: Upgrade INTL ICU to version 58 (Steven R. Loomis) #9234 * process: add `process.memoryUsage.external` (Fedor Indutny) #9587 * src: add wrapper for process.emitWarning() (Sam Roberts) #9139 Notable SEMVER-PATCH changes include: * fs: cache non-symlinks in realpathSync. (Jeremy Yallop) #10253 * repl: allow autocompletion for scoped packages (Evan Lucas) #10296 PR-URL: #10974

Notable Changes: * child_process: add shell option to spawn() (cjihrig) nodejs/node#4598 * crypto: * add ALPN Support (Shigeki Ohtsu) nodejs/node#2564 * allow adding extra certs to well-known CAs (Sam Roberts) nodejs/node#9139 * deps: * v8: expose statistics about heap spaces (Ben Ripkens) nodejs/node#4463 * fs: add the fs.mkdtemp() function. (Florian MARGAINE) nodejs/node#5333 * process: * add `externalMemory` to `process` (Fedor Indutny) nodejs/node#9587 * add process.cpuUsage() (Patrick Mueller) nodejs/node#10796 Signed-off-by: Ilkka Myller <[email protected]>

Notable Changes: The SEMVER-MINOR changes include: * crypto: allow adding extra certs to well-known CAs (Sam Roberts) nodejs/node#9139 * deps: Upgrade INTL ICU to version 58 (Steven R. Loomis) nodejs/node#9234 * process: add `process.memoryUsage.external` (Fedor Indutny) nodejs/node#9587 * src: add wrapper for process.emitWarning() (Sam Roberts) nodejs/node#9139 Notable SEMVER-PATCH changes include: * fs: cache non-symlinks in realpathSync. (Jeremy Yallop) nodejs/node#10253 * repl: allow autocompletion for scoped packages (Evan Lucas) nodejs/node#10296 Signed-off-by: Ilkka Myller <[email protected]>

Notable Changes: * child_process: add shell option to spawn() (cjihrig) nodejs/node#4598 * crypto: * add ALPN Support (Shigeki Ohtsu) nodejs/node#2564 * allow adding extra certs to well-known CAs (Sam Roberts) nodejs/node#9139 * deps: * v8: expose statistics about heap spaces (Ben Ripkens) nodejs/node#4463 * fs: add the fs.mkdtemp() function. (Florian MARGAINE) nodejs/node#5333 * process: * add `externalMemory` to `process` (Fedor Indutny) nodejs/node#9587 * add process.cpuUsage() (Patrick Mueller) nodejs/node#10796 Signed-off-by: Ilkka Myller <[email protected]>

Notable Changes: The SEMVER-MINOR changes include: * crypto: allow adding extra certs to well-known CAs (Sam Roberts) nodejs/node#9139 * deps: Upgrade INTL ICU to version 58 (Steven R. Loomis) nodejs/node#9234 * process: add `process.memoryUsage.external` (Fedor Indutny) nodejs/node#9587 * src: add wrapper for process.emitWarning() (Sam Roberts) nodejs/node#9139 Notable SEMVER-PATCH changes include: * fs: cache non-symlinks in realpathSync. (Jeremy Yallop) nodejs/node#10253 * repl: allow autocompletion for scoped packages (Evan Lucas) nodejs/node#10296 Signed-off-by: Ilkka Myller <[email protected]>

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 12, 2016

indutny added process Issues and PRs related to the process subsystem. lts-watch-v4.x semver-minor PRs that contain new features and should be released in the next minor version. labels Nov 12, 2016

indutny force-pushed the feature/memory-usage-external branch from d5349b9 to f2f5efc Compare November 12, 2016 23:49

bnoordhuis approved these changes Nov 13, 2016

View reviewed changes

mcollina approved these changes Nov 13, 2016

View reviewed changes

targos approved these changes Nov 13, 2016

View reviewed changes

indutny force-pushed the feature/memory-usage-external branch from f2f5efc to 2172c06 Compare November 13, 2016 09:31

jbergstroem approved these changes Nov 13, 2016

View reviewed changes

cjihrig approved these changes Nov 13, 2016

View reviewed changes

silverwind approved these changes Nov 13, 2016

View reviewed changes

addaleax approved these changes Nov 13, 2016

View reviewed changes

process: add process.memoryUsage.external

e35f0e2

indutny force-pushed the feature/memory-usage-external branch from 2172c06 to e35f0e2 Compare November 13, 2016 20:46

indutny closed this Nov 13, 2016

indutny deleted the feature/memory-usage-external branch November 13, 2016 20:49

Fishrock123 mentioned this pull request Nov 22, 2016

v7.2.0 proposal #9745

Merged

2 tasks

MylesBorins added the lts-agenda label Dec 21, 2016

MylesBorins mentioned this pull request Jan 6, 2017

Potential Semver Minor Backports nodejs/Release#177

Closed

9 tasks

MylesBorins added land-on-v4.x and removed lts-agenda labels Jan 13, 2017

This was referenced Jan 24, 2017

v4.8.0 proposal #10973

Merged

v6.10.0 proposal #10974

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

process: add `externalMemory` to process.memoryUsage #9587

process: add `externalMemory` to process.memoryUsage #9587

indutny commented Nov 12, 2016

indutny commented Nov 12, 2016

mscdex commented Nov 12, 2016

indutny commented Nov 12, 2016

indutny commented Nov 12, 2016

mcollina left a comment

targos Nov 13, 2016

indutny Nov 13, 2016

indutny commented Nov 13, 2016

jbergstroem commented Nov 13, 2016

silverwind left a comment

addaleax left a comment

indutny commented Nov 13, 2016

bnoordhuis commented Nov 13, 2016

indutny commented Nov 13, 2016

process: add externalMemory to process.memoryUsage #9587

process: add externalMemory to process.memoryUsage #9587

Conversation

indutny commented Nov 12, 2016

Checklist

Affected core subsystem(s)

Description of change

indutny commented Nov 12, 2016

mscdex commented Nov 12, 2016

indutny commented Nov 12, 2016

indutny commented Nov 12, 2016

mcollina left a comment

Choose a reason for hiding this comment

targos Nov 13, 2016

Choose a reason for hiding this comment

indutny Nov 13, 2016

Choose a reason for hiding this comment

indutny commented Nov 13, 2016

jbergstroem commented Nov 13, 2016

silverwind left a comment

Choose a reason for hiding this comment

addaleax left a comment

Choose a reason for hiding this comment

indutny commented Nov 13, 2016

bnoordhuis commented Nov 13, 2016

indutny commented Nov 13, 2016

process: add `externalMemory` to process.memoryUsage #9587

process: add `externalMemory` to process.memoryUsage #9587