Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix V8 patch #9610

Merged
merged 2 commits into from
Nov 17, 2016
Merged

Fix V8 patch #9610

merged 2 commits into from
Nov 17, 2016

Commits on Nov 17, 2016

  1. deps: revert botched V8 backport 

    Original Commit Message:
"build: cherry pick V8 change for windows DLL support"

This reverts commit 92ecbc4.

The original commit did not include the entire changeset
    Myles Borins committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    e893986 View commit details
    Browse the repository at this point in the history

  2. deps: cherry-pick 6f68f30 from v8 upstream 

    Original commit message:

[build] Add force_dynamic_crt option to build a static library with /…
…MD on windows

Adds option to build a V8 library statically, but with the options on
windows that allows it to be subsequently included in another DLL. On
Windows this is required for it to correclty link against the correct
C++ runtime. Require for our Node.js shared library build.

Reference:  nodejs#7487

BUG=
[email protected], [email protected]

Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d
Review-Url: https://codereview.chromium.org/2149963002
Cr-Original-Commit-Position: refs/heads/master@{nodejs#37814}
Cr-Commit-Position: refs/heads/master@{nodejs#37856}

Ref: nodejs#7802
Ref: nodejs#8084
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
    @stefanmb
    stefanmb authored and Myles Borins committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    fb635f6 View commit details
    Browse the repository at this point in the history