Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link & uniform formatting of SHAs in commit list #967

Closed
wants to merge 1 commit into from

Conversation

timoxley
Copy link
Contributor

This adds more consistency, plus links to commits are particularly useful.

FYI process was:

  1. Click the io.js "new issue" button
  2. Paste in the CHANGELOG markdown
  3. Click "Preview". Note that plaintext commit SHAs in issues are automatically turned into HTML links.
  4. Use devtools to grab generated HTML (now with commit links) from the preview
  5. Drop HTML into an HTML -> Markdown editor: https://domchristie.github.io/to-markdown/
  6. Copy/paste result into text editor
  7. Use regexes to clean up formatting

This adds more consistency, plus links to commits are particularly useful.
rvagg pushed a commit that referenced this pull request Feb 26, 2015
This adds more consistency, plus links to commits are particularly useful.

PR-URL: #967
Reviewed-By: Rod Vagg <[email protected]>
@rvagg
Copy link
Member

rvagg commented Feb 26, 2015

lgtm

landed @ 2e63bad with edited commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants