Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix faulty logic in iv size check (backport #9032) #9687

Closed
wants to merge 1 commit into from
Closed

crypto: fix faulty logic in iv size check (backport #9032) #9687

wants to merge 1 commit into from

Commits on Nov 18, 2016

  1. crypto: fix faulty logic in iv size check 

    Fix a regression introduced in commit 2996b5c ("crypto: Allow GCM
ciphers to have a longer IV length") from April 2016 where a misplaced
parenthesis in a 'is ECB cipher?' check made it possible to use empty
IVs with non-ECB ciphers.

Also fix some exit bugs in test/parallel/test-crypto-authenticated.js
that were introduced in commit 4a40832 ("test: cleanup IIFE tests")
where removing the IFFEs made the test exit prematurely instead of just
skipping subtests.

PR-URL: nodejs#9032
Refs: nodejs#6376
Refs: nodejs#9024
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
    @bnoordhuis @sam-github
    bnoordhuis authored and sam-github committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    0855c18 View commit details
    Browse the repository at this point in the history