add support for v8-canary builds #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocgreis
approved these changes
Jun 13, 2017
joaocgreis
reviewed
Jun 13, 2017
test.js
Outdated
| } | ||
| } | ||
|
|
||
| listBuilds('nightly', { releaseUrlBase: 'https://nodejs.org/download/' }, verify()) | ||
| listBuilds('nightly', verify()) |
There was a problem hiding this comment.
Missing an empty config parameter, here and in v8-canary below.
|
@rvagg added a commit to address my review. Do you mind if I go ahead and land this? this has been live in the server for some months now. |
SGTM |
joaocgreis
pushed a commit
that referenced
this pull request
Nov 2, 2017
PR-URL: #1 Reviewed-By: João Reis <[email protected]>
|
Landed in e0a745d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.