Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Tracing WG to Diagnostics WG #1009

Merged
merged 6 commits into from
Nov 4, 2016
Merged

Change Tracing WG to Diagnostics WG #1009

merged 6 commits into from
Nov 4, 2016

Conversation

ryanmurakami
Copy link
Contributor

The Tracing working group has become the Diagnostics working group and expanded their scope.
This PR updates the group's information on the working groups page.

This change would need to be updated for other localized sites that include the same page:
@nodejs/nodejs-ko
@nodejs/nodejs-uk

@williamkapke
Copy link
Contributor

Hm. Pls hold off on merging this for a few min while I review.

@williamkapke
Copy link
Contributor

I guess I'm late to the game on this topic unfortunately.

@joshgav was this expansion of the WG's charter approved by the CTC?

I see these PRs:
nodejs/diagnostics#47
nodejs/node#9329

But I don't see a discussion with the CTC requesting to expand the official charter. I feel confident that the CTC would approve it- but I just want to make sure we take the steps to ensure documentation and process.

Maybe this was done and I just wasn't able to find it?

Copy link
Contributor

@williamkapke williamkapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of mixing off-topic formatting changes in a PR.

@joshgav
Copy link
Contributor

joshgav commented Nov 4, 2016

@williamkapke discussion and conclusion are in nodejs/diagnostics#46, we made this change around when v8_inspector first came in in spring 2016 but missed propagating it in various docs.

Do you think we should have had a more official measure then?

@ryanmurakami - thanks for updating this!

@ryanmurakami
Copy link
Contributor Author

@williamkapke I hear you on mixing changes. I backed out everything except the tracing->diagnostics change and will open a separate PR for that. Thanks!

@williamkapke
Copy link
Contributor

@joshgav I had seen that post- but missed how old it was!

yeah- I would have pushed for a more formal process of approval at the time but it is really too far in the past to bring it up now! As I said- I'd find it really hard to believe the CTC would NOT approve it anyhow. There certain hasn't been any objections since the change :P

Hopefully, this thread can serve to help document it even more and some future person will understand how it all went down. heh. Thanks.

LGTM. Let's merge it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants