Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display LTS and Stable on the download page #261

Closed
wants to merge 1 commit into from

Conversation

phillipj
Copy link
Member

A pragmatic approach to toggling between LTS and Stable downloads. Duplicated the download page to have two separate pages: /download for LTS and /download/stable for Stable.

Two links in the upper right corner will appear as soon as the https://nodejs.org/dist/index.json contains both an LTS and a Stable v5.x release. Until then, no extra links will be visible.

Default is LTS

screen shot 2015-10-19 at 20 15 14

When toggled to Stable

screen shot 2015-10-19 at 20 15 21

Any thoughts? Are we okey with two different pages/URLs or would doing some JS trickery by changing the link URLs on the page be preferred?

Refs #200.

@bnb
Copy link
Contributor

bnb commented Oct 19, 2015

+1, LGTM.

@phillipj
Copy link
Member Author

@fhemberger @mikeal in regards to translation efforts, are you okay with having duplicate translation (and layout) files for the LTS and Stable download pages? The biggest advantages of doing this is possibly having different content on the these two pages and less JS trickeries.

@fhemberger
Copy link
Contributor

@phillipj I would prefer having a partial where you inject either project.currentVersion.stable or project.currentVersion.lts, e.g:

{{> download-matrix version=project.currentVersion.stable}}

This would be much easier to keep in sync.

@mikeal
Copy link
Contributor

mikeal commented Oct 27, 2015

@phillipj also, you can already add localization specific styles if what you nee to accomplish is doable with just CSS.

@phillipj phillipj force-pushed the lts-n-stable-downloads branch 2 times, most recently from 65c3d8c to e6e378d Compare October 28, 2015 07:44
@phillipj
Copy link
Member Author

@fhemberger good idea about using a partial 👍 Just pushed an update adding download-matrix

@fhemberger fhemberger mentioned this pull request Oct 29, 2015
@fhemberger fhemberger modified the milestone: 5.0.0 Oct 29, 2015
Duplicated the download page to have two separate
pages for each release line: LTS and Stable.

Two links in the upper right corner will appear
as soon as the https://nodejs.org/dist/index.json
contains *both* an LTS and a Stable v5.x release.
Until then, no extra links will be visible.
@phillipj
Copy link
Member Author

@fhemberger I just fixed the merge conflict after you merged #260

@fhemberger
Copy link
Contributor

@phillipj Dang, just merged it (fixing the conflict). Can you please have a look if I merged the correct solution in 6007cb7?

@fhemberger fhemberger closed this Oct 29, 2015
@phillipj
Copy link
Member Author

@fhemberger no worries, both versions of the conflict worked :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants