-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display LTS and Stable on the download page #261
Conversation
+1, LGTM. |
@fhemberger @mikeal in regards to translation efforts, are you okay with having duplicate translation (and layout) files for the LTS and Stable download pages? The biggest advantages of doing this is possibly having different content on the these two pages and less JS trickeries. |
@phillipj I would prefer having a partial where you inject either
This would be much easier to keep in sync. |
@phillipj also, you can already add localization specific styles if what you nee to accomplish is doable with just CSS. |
65c3d8c
to
e6e378d
Compare
@fhemberger good idea about using a partial 👍 Just pushed an update adding |
Duplicated the download page to have two separate pages for each release line: LTS and Stable. Two links in the upper right corner will appear as soon as the https://nodejs.org/dist/index.json contains *both* an LTS and a Stable v5.x release. Until then, no extra links will be visible.
e6e378d
to
68b3e3e
Compare
@fhemberger I just fixed the merge conflict after you merged #260 |
@fhemberger no worries, both versions of the conflict worked :) |
A pragmatic approach to toggling between LTS and Stable downloads. Duplicated the download page to have two separate pages:
/download
for LTS and/download/stable
for Stable.Two links in the upper right corner will appear as soon as the https://nodejs.org/dist/index.json contains both an LTS and a Stable v5.x release. Until then, no extra links will be visible.
Default is LTS
When toggled to Stable
Any thoughts? Are we okey with two different pages/URLs or would doing some JS trickery by changing the link URLs on the page be preferred?
Refs #200.