-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update schedule.json #2757
update schedule.json #2757
Conversation
1. According to our plan in https://nodejs.org/en/about/releases/, we've now published the 13th version of Nodejs, add this to the schedule for the maintance. 2. Add the missing coding name for v12.
Looks good to me but I never even noticed this file before (that I can remember anyway) so I'll leave the actual approving to others (which has already happened anyway). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Should the build just curl this file from https://github.com/nodejs/Release/blob/master/schedule.json instead of keeping a separate copy? |
@nschonni: Not sure yet, but according to your description, it seems this file here is duplicated? |
I think the file in the repository is a placeholder that gets overridden during build by Lines 12 to 14 in 575a47e
|
Can't we remove the folder and the file completely? |
So this file should be totally removed, or just run the script to update the file, just like what I submitted? |
This patch is moot since this is overwritten on build time. We should instead see if we can just remove the folder and the file. |
According to our plan in https://nodejs.org/en/about/releases/, we've now published the 13th version of Nodejs, add this to the schedule for the maintance.
Add the missing coding name for v12.