Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove misleading note section #2827

Merged
merged 5 commits into from
Dec 23, 2019
Merged

fix: remove misleading note section #2827

merged 5 commits into from
Dec 23, 2019

Conversation

szhigunov
Copy link
Contributor

@szhigunov szhigunov commented Dec 16, 2019 •
edited
Loading

Section misleading about setImmediate using in different environments.

Fixes: nodejs/node#30801

@szhigunov
Copy link
Contributor Author

If that PR will be accepted as appropriate, should I update other locales too?

@SEWeiTung
Copy link
Contributor

@Fishrock123：It's fine with me, what about your ideas?

@MylesBorins MylesBorins merged commit 5f6f0d3 into nodejs:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@SEWeiTung SEWeiTung SEWeiTung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: fix recommendation of setImmediate() over process.nextTick()
4 participants
@szhigunov @SEWeiTung @Trott @MylesBorins