document build.js #396
Merged
document build.js #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
ping @nodejs/website |
|
I think most of that was written between @fhemberger and @phillipj so they are probably best to review. |
|
👍 for comments!!! |
|
|
||
| 'use strict' | ||
|
|
||
| // BUILD.JS: This file is responsible for building the HTML site and serving it | ||
| // as a static server. |
There was a problem hiding this comment.
"This file is responsible for building static HTML pages and a server for local development."?
|
Very nice work @sup! The setup isn't very self explanatory for new comers, hopefully these comments will make it a lot easier too grasp 👍 Other than the comments, this LGTM. |
ghost
merged commit 
This was referenced Jun 21, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is something that i've been wanting to do for a longer time now. let's document the quite complicated (for a metalsmith build script at least)
build.jsfile.i've started and added some base comments. if any of those are wrong or superfluous, please let me know. also let me know if there's something left to be documented!