Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add winget (Official Package Manager for Windows) #4028

Merged
merged 9 commits into from
Dec 10, 2021
Merged

Add winget (Official Package Manager for Windows) #4028

merged 9 commits into from
Dec 10, 2021

Conversation

Sarveshmrao
Copy link
Contributor

Add winget (Official Package Manager for Windows) as an alternative install method for Windows. Also, the link at line #32 points to line #243 instead of line #353.

Add winget (Official Package Manager for Windows) as an alternative install method for Windows. Also, the link at line #32 points to line #243 instead of line #353.
@Trott
Copy link
Member

Trott commented Aug 8, 2021

@nodejs/platform-windows

@Sarveshmrao
Copy link
Contributor Author

@Trott NodeJS using winget works. Just the docs need to be updated. I don't understand what you are telling! If you explain more I would know.!

@Trott
Copy link
Member

Trott commented Aug 8, 2021

@Trott NodeJS using winget works. Just the docs need to be updated. I don't understand what you are telling! If you explain more I would know.!

I'm not sure I understand what you're asking. All I did was notify the Node.js people who identify as Windows folks to determine whether the content here is correct and warrants adding to the website. I have no opinion myself because I am not a Windows user and don't know much about Windows package managers etc.

locale/en/download/package-manager.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it might be fine, but would like clarification on expectations when running that command…

@DerekNonGeneric
Copy link
Contributor

Hopefully, I've done a good job setting up expectations for Windows users (it may not be clear that this adds a Node.js folder to the Start menu; I've added a screencap below), and whoever maintains those are pleased w/ the result — would certainly hope these would continue to be synchronized w/ our releases and wonder if it's fully automated at this point, but in the interest of fairness, I don't imagine turning a PR like this away would be appropriate.


image

Due to there being such a small representation of Windows users in our collaborator base, I guess it comes down to whether @ItzLevvie thinks it looks good to her or if there is anything else we could improve upon before merging this.

@ItzLevvie
Copy link
Contributor

cc @DerekNonGeneric: It looks good to me :)

Node.js releases, such as Current and LTS, are automated by a few contributors using their own scripts in the winget-pkgs repository.

@DerekNonGeneric DerekNonGeneric merged commit bb77ca3 into nodejs:main Dec 10, 2021
@Sarveshmrao Sarveshmrao deleted the patch-1 branch December 12, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants