fix changelog links for new 0.12 and 0.10 releases #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=@nodejs/website |
Fishrock123
force-pushed
the
fix-changelog-links
branch
from
541e6f8
to
9d3a781
Compare
|
LGTM |
| @@ -9,5 +9,10 @@ module.exports = function (version) { | |||
| return `https://github.com/nodejs/node/blob/${version}/CHANGELOG.md` | |||
| } | |||
|
|
|||
| // 0.12.8+ and 0.10.41+ releases come from the new repo | |||
| if (semver.satisfies(version, '~0.12.8 || ~0.10.41')) { | |||
| return `https://github.com/nodejs/node/blob/${version}/ChangeLog` | |||
There was a problem hiding this comment.
does this not need to be ChangeLog.md?
There was a problem hiding this comment.
@thealphanerd It was not markdown until io.js v1.0.0.
There was a problem hiding this comment.
oh my bad... I was misunderstanding what the bug was. nothing to see here :D
|
Ignore the noise above... LGTM |
stevemao
added a commit
that referenced
this pull request
Feb 3, 2016
fix changelog links for new 0.12 and 0.10 releases
This was referenced Jun 21, 2023
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #504
PR-URL: #505