Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Blog pagination / Blog category listing #6113

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

canerakdas
Copy link
Member

Description

This PR fixes the pagination and category listings on blog category pages

Validation

In the preview;

  • The Blog category page, Newer, Older buttons should work properly.
  • Blog category pages should work properly. (/en/blog/announcements, /en/blog/release, etc.)
  • In general checking blog pages would be great

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested review from a team as code owners November 14, 2023 16:54
Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 4:55pm

Copy link

github-actions bot commented Nov 14, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 97 🟠 83 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟠 83 🟢 92 🔗
/en/about/previous-releases 🟢 98 🟢 96 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟠 83 🟢 92 🔗
/en/blog 🟢 100 🟢 97 🟠 83 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
79.34% (361/455) 64.81% (70/108) 63.04% (58/92)

Unit Test Report

Tests Skipped Failures Errors Time
54 0 💤 0 ❌ 0 🔥 5.034s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I've missed this current category filtering. I've probably done a mistake when changing during the transition to App Router.

@ovflowd ovflowd added this pull request to the merge queue Nov 14, 2023
@ovflowd
Copy link
Member

ovflowd commented Nov 14, 2023

cc @nodejs/nodejs-website fast-tracking as a critical bug fix.

@ovflowd ovflowd removed this pull request from the merge queue due to a manual request Nov 14, 2023
@ovflowd ovflowd merged commit c7291c8 into nodejs:main Nov 14, 2023
13 checks passed
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants