About: update example to use better practices #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wouldn't no-semicolons be kind of alienating to some users? |
|
Shouldn't be. Since is the official documentation it should be noted that it will most definitely work, and will prepare people for the inevitable hordes of semicolonless code people will see in various modules. :) |
| res.setHeader('Content-Type', 'text/plain') | ||
| res.end('Hello World\n') | ||
| }) | ||
| server.listen(port, hostname, () => { |
There was a problem hiding this comment.
can we put one blank line between this line and the previous?
Fishrock123
force-pushed
the
semicolonless
branch
from
bfa269c
to
2131b1a
Compare
|
LGTM :) |
ghost
merged commit
|
pardon me but um
|
|
nvm I'll just make a test PR then |
|
@Fishrock123 wow i cant read |
|
Can we put back the semicolons? I think this is inconsistent with the API docs where semicolons are always used. It's just an OCD of mine, don't want to start yet another semicolons discussion. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also for testing the latest https://github.com/nodejs-github-bot/github-bot