-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(layout): Refractoring #6929
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Is this still a draft? |
Yes and no. Basically, the component and file names are clearly not the right ones. But I have no idea. |
Is the only thing blocking this the naming? |
Yeah 😅 I'm not fan about how layout is named |
ArticlePageLayout? |
I'm working on this addition to the COLLABORATOR_GUIDE. I was hoping it would help us identify the LayoutsThere are several Layouts available within the Website. Here's a comparison of their features:
|
Centered and home can be merge; and content with post ? |
If it works, it works. Do it. |
This comment was marked as outdated.
This comment was marked as outdated.
4e1b168
to
85e4004
Compare
This PR solves more than one problem (#7062, #6922) and simplifies the layouts, do you have time to resolve the conflict @AugustinMauroy 🙇 I have availability this week and I can help too if you want 👀 |
@canerakdas it's not overcomplicated just need to open spotify 😁 |
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎵 I checked the layouts in general for desktop and mobile resolution. Thank you @AugustinMauroy
Description
metabar
Related Issues
It's one solution for #6922
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.