Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): Refractoring #6929

Merged
merged 4 commits into from
Oct 10, 2024
Merged

feat(layout): Refractoring #6929

merged 4 commits into from
Oct 10, 2024

Conversation

AugustinMauroy
Copy link
Contributor

@AugustinMauroy AugustinMauroy commented Jul 17, 2024

Description

  • Remove handwritten ToC, and use metabar
  • Clean and merge some layout to simplify our logic.

Related Issues

It's one solution for #6922

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 9, 2024 5:59pm

@ovflowd
Copy link
Member

ovflowd commented Jul 20, 2024

Is this still a draft?

@AugustinMauroy
Copy link
Contributor Author

Is this still a draft?

Yes and no. Basically, the component and file names are clearly not the right ones. But I have no idea.
But from a code point of view nothing will change in my opinion

@AugustinMauroy AugustinMauroy marked this pull request as ready for review August 15, 2024 08:43
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner August 15, 2024 08:43
@bmuenzenmeyer
Copy link
Collaborator

Is the only thing blocking this the naming?

@AugustinMauroy
Copy link
Contributor Author

Yeah 😅 I'm not fan about how layout is named

@mikeesto
Copy link
Member

ArticlePageLayout?

@bmuenzenmeyer
Copy link
Collaborator

I'm working on this addition to the COLLABORATOR_GUIDE. I was hoping it would help us identify the SimplePage uniqueness, and perhaps simplify our layouts - we have a LOT

Layouts

There are several Layouts available within the Website. Here's a comparison of their features:

Layout Includes Layout... WithNavBar WithSidebar WithFooter WithMetaBar WithBreadcrumbs Comment / Custom Element(s)
Default Article
About Article
SimplePage Article
Learn Article WithSidebarCrossLinks
Post Content WithBlogCrossLinks
Blog WithBlogCategories
Download WithDownloadCategories
Search
Centered
Base NotificationProvider and NavigationStateProvider
Home Centered GlowingBackdrop
Article CSS Only
Content CSS Only

@AugustinMauroy
Copy link
Contributor Author

AugustinMauroy commented Sep 10, 2024

Centered and home can be merge; and content with post ?

@ovflowd
Copy link
Member

ovflowd commented Sep 11, 2024

Centered and home can be merge; and content with post ?

If it works, it works. Do it.

@AugustinMauroy AugustinMauroy changed the title feat(layout): introduce SimplePage feat(layout): Refractoring Sep 12, 2024
@ovflowd

This comment was marked as outdated.

Copy link

github-actions bot commented Sep 14, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.329s ⏱️

@canerakdas
Copy link
Member

This PR solves more than one problem (#7062, #6922) and simplifies the layouts, do you have time to resolve the conflict @AugustinMauroy 🙇

I have availability this week and I can help too if you want 👀

@AugustinMauroy
Copy link
Contributor Author

@canerakdas it's not overcomplicated just need to open spotify 😁

Copy link

github-actions bot commented Oct 9, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎵 I checked the layouts in general for desktop and mobile resolution. Thank you @AugustinMauroy

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit f116efe Oct 10, 2024
16 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the fix-nav branch October 10, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The table of contents does not work for translated pages for community package managers
5 participants