-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SunOS and ARM binaries to download matrix #87
Conversation
cc @nodejs/build I don't think we'll have 32-bit mac ones? Not sure about smartos. @phillipj |
Also I suggest listing the |
@Fishrock123 ARM indeed! Maybe I should make a separate PR ready to be merged when v4 arrives, which has ARM and |
See: https://iojs.org/dist/v3.3.0/ I'd target 4.0.0. It should drop next monday/tuesday. |
eeek, tbh I hadn't factored in |
Ok @Fishrock123, I'll revise to target v4 instead. @rvagg np, just say the word if I should remove SunOS again. |
be424cc
to
a2f9a0f
Compare
Pushed some changes targeting node v4 and new paths:
Dont merge until v4 has been released! UPDATED |
Just to complicate matters we also have ARMv8 in the mix now, also reffered to as AARCH64 although "ARMv8" is probably good enough, maybe "ARMv8 64-bit". Also, I'm not sure how Solaris folks feel about naming and whether "SunOS" makes sense these days. Honestly I have no idea but /cc @nodejs/build for help on naming here. Strictly speaking they are SmartOS. |
Would appreciate some suggestions about exposing |
You could always have a link down the bottom that says "All download options" that just links to the dist directory and they can figure it out, then you could avoid the more obscure platforms in the main table |
I think that's the best solution, only show the most popular platforms. |
@rvagg can't really back any claims up, but I reckon the smartos/sunos binaries can be run on Illumos, OmniOS et al as well (SmartOS is actually a derivative of Illumos). Just saying that |
@jbergstroem right, but is "SunOS" right here? Should it be "Solaris"? |
https://nodejs.org/download/nightly/v4.0.0-nightly201509079cae65c510/ has all of the download asset types that we're going to be going live with when we do v4.0.0, including "sunos-x64", "sunos-x86" and "linux-arm64" which are missing from RC 1. See https://nodejs.org/download/nightly/ for an index.tab and index.json with the full data if you want that for testing. |
a2f9a0f
to
fa33094
Compare
These URLs are targeted for the first node v4 release, some of these URLs does not exist for prior releases. Changed "universal" -> "64bit" for Mac binaries as they're not 32-bit compatible any longer in node v4. Added "All download options" below matrix. Also prepended http://nodejs.org to all downloads URLs.
fa33094
to
d650d00
Compare
Wikipedia:
Just go with SunOS I guess, wait till someone complains, which I'm sure they will if that's wrong |
@rvagg I wonder if it even works on solaris.. reckon less change is better for now. |
I merged this already into a separate node-4.0-release branch, so all required changes can go live at the same time. |
Sounds like a good plan @fhemberger 👍 I'm closing this PR then. |
SunOS and 32-bit Mac binaries was not added to the download matrix in the first place as iojs doesnt have these binaries and this site consisted only of iojs as of last week.
Also prepended http://nodejs.org to all downloads URLs, frustrating to get 404 requests when clicking these downloads link when running locally..
Will node v4 have SunOS and 32-bit mac binaries @rvagg?
BEFORE
AFTER