Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SunOS and ARM binaries to download matrix #87

Closed
wants to merge 1 commit into from

Conversation

phillipj
Copy link
Member

@phillipj phillipj commented Sep 3, 2015

SunOS and 32-bit Mac binaries was not added to the download matrix in the first place as iojs doesnt have these binaries and this site consisted only of iojs as of last week.

Also prepended http://nodejs.org to all downloads URLs, frustrating to get 404 requests when clicking these downloads link when running locally..

Will node v4 have SunOS and 32-bit mac binaries @rvagg?

BEFORE

image

AFTER

image

@Fishrock123
Copy link
Contributor

cc @nodejs/build

I don't think we'll have 32-bit mac ones? Not sure about smartos.

@phillipj
This page, however is greatly missing the ARM binaries, which are probably more important. :)

@Fishrock123
Copy link
Contributor

Also I suggest listing the .xz versions of any *nix (not mac) binaries. But that may not be correct. I'll let others chime in.

@phillipj
Copy link
Member Author

phillipj commented Sep 3, 2015

@Fishrock123 ARM indeed! Maybe I should make a separate PR ready to be merged when v4 arrives, which has ARM and .xz? As this was primarly meant to fix what's lacking in production at the moment for v0.12...

@Fishrock123
Copy link
Contributor

See: https://iojs.org/dist/v3.3.0/

I'd target 4.0.0. It should drop next monday/tuesday.

@rvagg
Copy link
Member

rvagg commented Sep 4, 2015

eeek, tbh I hadn't factored in sunos binaries for v4 but I should have a quick look at adding that back in, I just don't know much about producing those so no promises

@phillipj
Copy link
Member Author

phillipj commented Sep 4, 2015

Ok @Fishrock123, I'll revise to target v4 instead.

@rvagg np, just say the word if I should remove SunOS again.

@phillipj
Copy link
Member Author

phillipj commented Sep 7, 2015

Pushed some changes targeting node v4 and new paths:

Dont merge until v4 has been released!

UPDATED

image

@rvagg
Copy link
Member

rvagg commented Sep 7, 2015

Just to complicate matters we also have ARMv8 in the mix now, also reffered to as AARCH64 although "ARMv8" is probably good enough, maybe "ARMv8 64-bit".

Also, I'm not sure how Solaris folks feel about naming and whether "SunOS" makes sense these days. Honestly I have no idea but /cc @nodejs/build for help on naming here. Strictly speaking they are SmartOS.

@phillipj
Copy link
Member Author

phillipj commented Sep 7, 2015

Would appreciate some suggestions about exposing .xz files aswell if we want those in there aswell. Little hesitant to almost doubling the amount of rows. What I've played with locally has ended up looking like a mess IMO, but I'm not the most creative UX person around :)

@rvagg
Copy link
Member

rvagg commented Sep 7, 2015

You could always have a link down the bottom that says "All download options" that just links to the dist directory and they can figure it out, then you could avoid the more obscure platforms in the main table

@phillipj phillipj changed the title Added SunOS and 32-bit Mac binaries to download matrix Added SunOS and ARM binaries to download matrix Sep 7, 2015
@fhemberger
Copy link
Contributor

I think that's the best solution, only show the most popular platforms.

@jbergstroem
Copy link
Member

@rvagg can't really back any claims up, but I reckon the smartos/sunos binaries can be run on Illumos, OmniOS et al as well (SmartOS is actually a derivative of Illumos). Just saying that smartos might not be the most correct choice hence staying with as-is is at least neutral.

@rvagg
Copy link
Member

rvagg commented Sep 7, 2015

@jbergstroem right, but is "SunOS" right here? Should it be "Solaris"?

@rvagg
Copy link
Member

rvagg commented Sep 7, 2015

https://nodejs.org/download/nightly/v4.0.0-nightly201509079cae65c510/ has all of the download asset types that we're going to be going live with when we do v4.0.0, including "sunos-x64", "sunos-x86" and "linux-arm64" which are missing from RC 1. See https://nodejs.org/download/nightly/ for an index.tab and index.json with the full data if you want that for testing.

@phillipj
Copy link
Member Author

phillipj commented Sep 7, 2015

Included three ARM types and added link for all downloads at the bottom.

The SunOS / Solaris / SmartOS is the last remaining puzzle.

UPDATED

image

These URLs are targeted for the first node v4 release,
some of these URLs does not exist for prior releases.

Changed "universal" -> "64bit" for Mac binaries
as they're not 32-bit compatible any longer in node v4.

Added "All download options" below matrix.

Also prepended http://nodejs.org to all downloads URLs.
@rvagg
Copy link
Member

rvagg commented Sep 7, 2015

Wikipedia:

SunOS is a version of the Unix operating system developed by Sun Microsystems for their workstation and server computer systems. The SunOS name is usually only used to refer to versions 1.0 to 4.1.4 of SunOS. These versions were based on BSD, while SunOS version 5.0 and later are based on UNIX System V Release 4, and are marketed under the brand name Solaris.

Just go with SunOS I guess, wait till someone complains, which I'm sure they will if that's wrong

@jbergstroem
Copy link
Member

@rvagg I wonder if it even works on solaris.. reckon less change is better for now.

@fhemberger
Copy link
Contributor

I merged this already into a separate node-4.0-release branch, so all required changes can go live at the same time.

@phillipj
Copy link
Member Author

phillipj commented Sep 7, 2015

Sounds like a good plan @fhemberger 👍 I'm closing this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants