Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Documentation for Adding Tools #202

Merged
merged 6 commits into from
May 13, 2019
Merged

Add Documentation for Adding Tools #202

merged 6 commits into from
May 13, 2019

Conversation

Emuentes
Copy link
Contributor

@Emuentes Emuentes commented May 6, 2019

No description provided.

@Emuentes Emuentes mentioned this pull request May 6, 2019
Closed
ljharb
ljharb reviewed May 6, 2019
View reviewed changes
docs/drafts/onboarding-tools Outdated Show resolved Hide resolved
docs/drafts/onboarding-tools Outdated Show resolved Hide resolved
Eomm
Eomm reviewed May 6, 2019
View reviewed changes
docs/drafts/onboarding-tools Outdated Show resolved Hide resolved
@Emuentes
Copy link
Contributor Author

Emuentes commented May 6, 2019

Changes implemented @Eomm @ljharb

Thanks for the review.

I'll leave this issue open until we discuss in the meeting on the 13th.

mhdawson
mhdawson approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Emuentes Emuentes merged commit 524da61 into nodejs:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@mhdawson mhdawson mhdawson approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Emuentes @ljharb @mhdawson @Eomm