Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Commit

Permalink
quic: use using declaration instead of explicit ns
Browse files Browse the repository at this point in the history
node_quic_http3_application.cc has a few v8 specific using declarations
but they are currently not used and instead explicit namespacing is
used. This commit updates the code to use the using declarations and
also removes the ones that are no longer in use.

PR-URL: #380
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
danbev committed May 4, 2020
1 parent be0bd95 commit d2ed3a8
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions src/quic/node_quic_http3_application.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@

namespace node {

using v8::Eternal;
using v8::MaybeLocal;
using v8::String;
using v8::Value;
using v8::Array;
using v8::Local;

namespace quic {

Expand Down Expand Up @@ -238,7 +236,7 @@ bool Http3Application::SubmitHeaders(
// SubmitHeaders() function on the created QuicStream.
BaseObjectPtr<QuicStream> Http3Application::SubmitPush(
int64_t id,
v8::Local<v8::Array> headers) {
Local<Array> headers) {
// If the QuicSession is not a server session, return false
// immediately. Push streams cannot be sent by an HTTP/3 client.
if (!session()->is_server())
Expand All @@ -262,7 +260,7 @@ BaseObjectPtr<QuicStream> Http3Application::SubmitPush(
// client
bool Http3Application::SubmitInformation(
int64_t stream_id,
v8::Local<v8::Array> headers) {
Local<Array> headers) {
if (!session()->is_server())
return false;
Http3Headers nva(session()->env(), headers);
Expand All @@ -273,7 +271,7 @@ bool Http3Application::SubmitInformation(
// submits response headers.
bool Http3Application::SubmitHeaders(
int64_t stream_id,
v8::Local<v8::Array> headers,
Local<Array> headers,
uint32_t flags) {
Http3Headers nva(session()->env(), headers);
return SubmitHeaders(stream_id, nva, flags);
Expand All @@ -282,7 +280,7 @@ bool Http3Application::SubmitHeaders(
// Submits trailing headers for the HTTP/3 request or response.
bool Http3Application::SubmitTrailers(
int64_t stream_id,
v8::Local<v8::Array> headers) {
Local<Array> headers) {
Http3Headers nva(session()->env(), headers);
return SubmitTrailers(stream_id, nva);
}
Expand Down

0 comments on commit d2ed3a8

Please sign in to comment.