Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

TODO: Improve connection close reporting #86

Closed
jasnell opened this issue Aug 22, 2019 · 2 comments
Closed

TODO: Improve connection close reporting #86

jasnell opened this issue Aug 22, 2019 · 2 comments
Assignees
@jasnell

Comments

@jasnell
Copy link
Member

jasnell commented Aug 22, 2019

When a QuicSession is closed with a received CONNECTION_CLOSE, make sure the connection close error code is transmitted out to the JavaScript side so the user can know why the connection was closed.
@jasnell jasnell self-assigned this Aug 23, 2019
@jasnell
Copy link
Member Author

jasnell commented Aug 23, 2019

There appears to be a limitation currently in the ngtcp2 where we cannot directly access the error_code from a received connection close... so while we can know that a connection has closed, we can't know exactly why yet. I've opened ngtcp2/ngtcp2#147 to get clarity.

@jasnell jasnell mentioned this issue Aug 23, 2019
Closed
4 tasks
@jasnell
Copy link
Member Author

jasnell commented Dec 3, 2019

Addressed in #207

jasnell added a commit to jasnell/quic that referenced this issue Dec 3, 2019
@jasnell
quic: capture received connection_close details
7d5277f 
Fixes: nodejs#86
jasnell added a commit to jasnell/quic that referenced this issue Dec 4, 2019
@jasnell
quic: capture received connection_close details
ea8c816 
Fixes: nodejs#86
@jasnell jasnell closed this as completed in 7736100 Dec 4, 2019
addaleax pushed a commit that referenced this issue Dec 11, 2019
@jasnell @addaleax
quic: capture received connection_close details
a469bc7 
Fixes: #86
PR-URL: #207
Reviewed-By: #207
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasnell jasnell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasnell