Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

quic: support memory tracking #145

Closed
wants to merge 2 commits into from
Closed

quic: support memory tracking #145

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Oct 2, 2019

Fixes: #59

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnell jasnell force-pushed the master branch 2 times, most recently from 89ce0dd to a529ed5 Compare October 3, 2019 00:06
@jasnell
Copy link
Member

jasnell commented Oct 3, 2019

Heads up, this will need to be rebased against master

@addaleax
Copy link
Member Author

addaleax commented Oct 3, 2019

Rebased

jasnell pushed a commit that referenced this pull request Oct 3, 2019
@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
7f6cbf2 
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 3, 2019
@addaleax @jasnell
quic: support memory tracking
3318dd7 
Fixes: #59
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 3, 2019

Landed!

@jasnell jasnell closed this Oct 3, 2019
jasnell pushed a commit that referenced this pull request Oct 3, 2019
@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
4183b11 
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 3, 2019
@addaleax @jasnell
quic: support memory tracking
d3d6ef1 
Fixes: #59
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 3, 2019
@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
963d54c 
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 3, 2019
@addaleax @jasnell
quic: support memory tracking
4835a89 
Fixes: #59
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Dec 11, 2019
@addaleax
src: allow unique_ptrs with custom deleter in memory tracker
ad9d240 
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Dec 11, 2019
@addaleax
quic: support memory tracking
455f965 
Fixes: #59
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
sam-github pushed a commit to sam-github/node that referenced this pull request Dec 13, 2019
@addaleax @sam-github
src: allow unique_ptrs with custom deleter in memory tracker
de1867b 
PR-URL: nodejs/quic#145
Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit to juanarbol/quic that referenced this pull request Dec 17, 2019
@addaleax @juanarbol
src: allow unique_ptrs with custom deleter in memory tracker
7bace89 
PR-URL: nodejs#145
Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit to juanarbol/quic that referenced this pull request Dec 17, 2019
@addaleax @juanarbol
quic: support memory tracking
a3fa3f2 
Fixes: nodejs#59
PR-URL: nodejs#145
Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit to juanarbol/quic that referenced this pull request Dec 17, 2019
@addaleax @juanarbol
quic: support memory tracking
b4e35f6 
Fixes: nodejs#59
PR-URL: nodejs#145
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
ac2d68b 
PR-URL: nodejs#145
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Feb 13, 2020
@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
6f5ad2c 
PR-URL: #145
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit to jasnell/node that referenced this pull request Feb 19, 2020
@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
d1317d0 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <[email protected]>
```
@jasnell jasnell mentioned this pull request Feb 19, 2020
Closed
3 tasks
jasnell pushed a commit to nodejs/node that referenced this pull request Feb 24, 2020
@addaleax @jasnell
src: allow unique_ptrs with custom deleter in memory tracker
e68d4c6 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <[email protected]>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit to nodejs/node that referenced this pull request Feb 27, 2020
@addaleax @codebytere
src: allow unique_ptrs with custom deleter in memory tracker
8fa6373 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <[email protected]>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit to nodejs/node that referenced this pull request Mar 15, 2020
@addaleax @codebytere
src: allow unique_ptrs with custom deleter in memory tracker
0403fcf 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <[email protected]>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit to nodejs/node that referenced this pull request Mar 17, 2020
@addaleax @codebytere
src: allow unique_ptrs with custom deleter in memory tracker
f66627c 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <[email protected]>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit to nodejs/node that referenced this pull request Mar 30, 2020
@addaleax @codebytere
src: allow unique_ptrs with custom deleter in memory tracker
3b2bbbd 
Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#145
  Reviewed-By: James M Snell <[email protected]>
```

PR-URL: #31870
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TODO: Need to fill out memory tracking
2 participants
@addaleax @jasnell