Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

quic: default options parameter in constructor #152

Closed
wants to merge 1 commit into from
Closed

quic: default options parameter in constructor #152

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 5, 2019

We need not default options parameter as {} is passed by default in createSocket

quic/lib/internal/quic/core.js

Lines 2311 to 2315 in 40e5be0

function createSocket(options = {}) {
if (options == null || typeof options !== 'object')
throw new ERR_INVALID_ARG_TYPE('options', 'Object', options);
return new QuicSocket(options);
}

Moving this change in the function signature.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

trivikr added a commit that referenced this pull request Oct 7, 2019
PR-URL: #152
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@trivikr
Copy link
Member Author

trivikr commented Oct 7, 2019

Landed in 92c25a6

@trivikr trivikr closed this Oct 7, 2019
addaleax pushed a commit that referenced this pull request Dec 11, 2019
PR-URL: #152
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
juanarbol pushed a commit to juanarbol/quic that referenced this pull request Dec 17, 2019
PR-URL: nodejs#152
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
juanarbol pushed a commit to juanarbol/quic that referenced this pull request Dec 17, 2019
PR-URL: nodejs#152
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants