This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
test: add tests for quic ipv6Only
#171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
reviewed
Oct 12, 2019
addaleax
reviewed
Oct 12, 2019
| type: Error, | ||
| // TODO(@oyyd): Currently we cann't know the exact "syscall" so that it's | ||
| // undefined here. | ||
| message: 'undefined EINVAL', |
There was a problem hiding this comment.
Just as a heads up, with #165 the syscall is correctly set to bind.
addaleax
approved these changes
Oct 12, 2019
Also fix some lint issues.
oyyd
force-pushed
the
test-quic-ipv6only
branch
from
444a99c
to
03571aa
Compare
trivikr
approved these changes
Oct 13, 2019
jasnell
approved these changes
Oct 14, 2019
danbev
pushed a commit
that referenced
this pull request
Oct 15, 2019
Also fix some lint issues. PR-URL: #171 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in b224c03 |
3 tasks
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
Also fix some lint issues. PR-URL: #171 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
Also fix some lint issues. PR-URL: nodejs#171 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
Also fix some lint issues. PR-URL: nodejs#171 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix some lint issues.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes