This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
quic: include limits in node_quic_util.h #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, limits is included implicitly through node_quic_buffer.h which includes node_internals.h, which includes util.h, which includes limits. This commit makes explicitely include limits.
jasnell
approved these changes
Nov 5, 2019
trivikr
approved these changes
Nov 5, 2019
addaleax
approved these changes
Nov 5, 2019
danbev
added a commit
that referenced
this pull request
Nov 6, 2019
Currently, limits is included implicitly through node_quic_buffer.h which includes node_internals.h, which includes util.h, which includes limits. This commit makes explicitely include limits. PR-URL: #190 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in f2a3a1d. |
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
Currently, limits is included implicitly through node_quic_buffer.h which includes node_internals.h, which includes util.h, which includes limits. This commit makes explicitely include limits. PR-URL: #190 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
Currently, limits is included implicitly through node_quic_buffer.h which includes node_internals.h, which includes util.h, which includes limits. This commit makes explicitely include limits. PR-URL: nodejs#190 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
Currently, limits is included implicitly through node_quic_buffer.h which includes node_internals.h, which includes util.h, which includes limits. This commit makes explicitely include limits. PR-URL: nodejs#190 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, limits is included implicitly through node_quic_buffer.h
which includes node_internals.h, which includes util.h, which includes
limits. This commit makes explicitely include limits.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes