This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
quic: replace unused includes in node_quic.cc #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the unused includes climits and algorithm, and adds memory (for std::unique_ptr) and utility (for std::move).
gengjiawen
approved these changes
Nov 18, 2019
danbev
added a commit
that referenced
this pull request
Nov 18, 2019
This commit removes the unused includes climits and algorithm, and adds memory (for std::unique_ptr) and utility (for std::move). PR-URL: #192 Reviewed-By: Jiawen Geng <[email protected]>
|
Landed in da5d7ba. |
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
This commit removes the unused includes climits and algorithm, and adds memory (for std::unique_ptr) and utility (for std::move). PR-URL: #192 Reviewed-By: Jiawen Geng <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
This commit removes the unused includes climits and algorithm, and adds memory (for std::unique_ptr) and utility (for std::move). PR-URL: nodejs#192 Reviewed-By: Jiawen Geng <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
This commit removes the unused includes climits and algorithm, and adds memory (for std::unique_ptr) and utility (for std::move). PR-URL: nodejs#192 Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the unused includes
climitsandalgorithm, and addsmemory(for std::unique_ptr) andutility(for std::move).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes